Re: [PATCH 4/8] v3 Allow memory_block to span multiple memory sections

Dave Hansen
2010-07-20T19:21:33Z

On Mon, 2010-07-19 at 22:55 -0500, Nathan Fontenot wrote:
> +static u32 get_memory_block_size(void)
> +{
> + u32 block_sz;
> +
> + block_sz = memory_block_size_bytes();
> +
> + /* Validate blk_sz is a power of 2 and not less than section size */
> + if ((block_sz & (block_sz - 1)) || (block_sz < MIN_MEMORY_BLOCK_SIZE))
> + block_sz = MIN_MEMORY_BLOCK_SIZE;

Is this worth a WARN_ON()? Seems pretty bogus if someone is returning
funky block sizes.

-- Dave