Re: [PATCH] tmio_mmc: Make ack_mmc_irqs() write-only

Magnus Damm
2010-07-23T11:10:12Z

2010/7/20 Yusuke Goda <yusuke.goda.sx@renesas.com>:
> This patch updates ack_mmc_irqs() to acknowledge using write instead
> of read-modify-write. Without this fix the old read-modify-write
> implementation may acknowledge interrupt sources by mistake. The
> driver may if so lock-up waiting forever for an interrupt that will
> never come. Observed with the TMIO_STAT_RXRDY bit together with CMD53
> on AR6002 and BCM4318 SDIO cards in polled mode.
>
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>

Simple testing with a BCM4318 card and a MMC card on sh7372 and SDHI
shows no problems.

Acked-by: Magnus Damm <damm@opensource.se>