From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
lrg@slimlogic.co.uk, akpm@linux-foundation.org,
a.zummo@towertech.it, gortmaker@yahoo.com,
kyungmin.park@samsung.com, m.szyprowski@samsung.com
Subject: Re: [PATCH 2/3] mfd: MAX8998: Add interrupts support
Date: Tue, 20 Jul 2010 18:54:04 +0900 [thread overview]
Message-ID: <4C45723C.1000009@samsung.com> (raw)
In-Reply-To: <20100720085554.GH10222@rakim.wolfsonmicro.main>
On 7/20/2010 5:55 PM, Mark Brown wrote:
> On Tue, Jul 20, 2010 at 03:57:37PM +0900, Joonyoung Shim wrote:
>> Use genirq and provide seperated file for interrupts support.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> ...
>
>> +
>> + for (i = 0; i < ARRAY_SIZE(max8998->irq_masks_cur); i++) {
>> + /*
>> + * If there's been a change in the mask write it back
>> + * to the hardware.
>> + */
>> + if (max8998->irq_masks_cur[i] != max8998->irq_masks_cache[i]) {
>> + max8998->irq_masks_cache[i] = max8998->irq_masks_cur[i];
>> + max8998_write_reg(max8998->i2c, MAX8998_REG_IRQM1 + i,
>> + max8998->irq_masks_cur[i]);
>> + }
>
> This code all looks oddly familiar :)
Yes, i didn't have any needs to use other way.
>
> Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
next prev parent reply other threads:[~2010-07-20 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 6:57 [PATCH 1/3] mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions Joonyoung Shim
2010-07-20 6:57 ` [PATCH 2/3] mfd: MAX8998: Add interrupts support Joonyoung Shim
2010-07-20 8:55 ` Mark Brown
2010-07-20 9:54 ` Joonyoung Shim [this message]
2010-07-25 21:52 ` Samuel Ortiz
2010-07-20 6:57 ` [PATCH 3/3] rtc: Add MAX8998 rtc driver Joonyoung Shim
2010-07-25 21:54 ` Samuel Ortiz
2010-07-27 14:52 ` Rabin Vincent
2010-07-25 21:51 ` [PATCH 1/3] mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C45723C.1000009@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gortmaker@yahoo.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox