From: "H. Peter Anvin" <hpa@zytor.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
James Smart <james.smart@emulex.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH] BISECTED x86: avoid qword access in memcpy_*io
Date: Wed, 21 Jul 2010 20:59:48 -0700 [thread overview]
Message-ID: <4C47C234.7040400@zytor.com> (raw)
In-Reply-To: <4C479D7F.2070204@jp.fujitsu.com>
On 07/21/2010 06:23 PM, Hidetoshi Seto wrote:
>
> It seems that lpfc already implemented lpfc_memcpy_{to,from}_slim()
> as such memcpy_*io32, but limited use of it to on big endian platforms
> only. Now lpfc can move to use it always, right?
>
What it probably should do is instead of open-coding this stuff use
__iowrite32_copy and we probably should have a version without double
underscores which byteswaps on bigendian.
Personally I would not object to seeing a patch renaming
__iowrite32_copy() to memcpy_toio32()... especially since it doesn't
have the "memory or I/O space" property of iowrite and friends.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2010-07-22 4:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 1:21 [PATCH] BISECTED x86: avoid qword access in memcpy_*io Hidetoshi Seto
2010-07-21 2:48 ` H. Peter Anvin
2010-07-22 1:23 ` Hidetoshi Seto
2010-07-22 2:33 ` H. Peter Anvin
2010-07-22 3:59 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C47C234.7040400@zytor.com \
--to=hpa@zytor.com \
--cc=brgerst@gmail.com \
--cc=james.smart@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox