public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: MMU: fix hugepage mapping corrupt caused by regression
@ 2010-07-23  5:16 Xiao Guangrong
  2010-07-25  8:48 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Guangrong @ 2010-07-23  5:16 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, LKML, KVM list

This is the regression, the bug which is fixed by commit e09e90a5
is active now

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
 arch/x86/kvm/paging_tmpl.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
index a09e04c..d9a2742 100644
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -374,13 +374,13 @@ static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr,
 	     shadow_walk_next(&it)) {
 		gfn_t direct_gfn;
 
+		validate_direct_spte(vcpu, it.sptep, direct_access);
+
 		drop_large_spte(vcpu, it.sptep);
 
 		if (is_shadow_present_pte(*it.sptep))
 			continue;
 
-		validate_direct_spte(vcpu, it.sptep, direct_access);
-
 		direct_gfn = gw->gfn & ~(KVM_PAGES_PER_HPAGE(it.level) - 1);
 
 		sp = kvm_mmu_get_page(vcpu, direct_gfn, addr, it.level-1,
-- 
1.6.1.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM: MMU: fix hugepage mapping corrupt caused by regression
  2010-07-23  5:16 [PATCH] KVM: MMU: fix hugepage mapping corrupt caused by regression Xiao Guangrong
@ 2010-07-25  8:48 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-07-25  8:48 UTC (permalink / raw)
  To: Xiao Guangrong; +Cc: Marcelo Tosatti, LKML, KVM list

  On 07/23/2010 08:16 AM, Xiao Guangrong wrote:
> This is the regression, the bug which is fixed by commit e09e90a5
> is active now
>

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-25  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-23  5:16 [PATCH] KVM: MMU: fix hugepage mapping corrupt caused by regression Xiao Guangrong
2010-07-25  8:48 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox