public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ortwin Glück" <odi@odi.ch>
To: Jike Song <albcamus@gmail.com>
Cc: linux-kernel@vger.kernel.org, Felix Fietkau <nbd@openwrt.org>,
	Vasanthakumar Thiagarajan <vasanth@atheros.com>
Subject: Re: BUG at arch/x86/mm/physaddr.c:5
Date: Fri, 23 Jul 2010 15:51:43 +0200	[thread overview]
Message-ID: <4C499E6F.8030507@odi.ch> (raw)
In-Reply-To: <AANLkTimn7Z3LqhLOt4_6ggFgjdzIZQPd_CznOIW-6D1N@mail.gmail.com>

On 23.07.2010 10:04, Jike Song wrote:
> Seems to be a logical error?  Does the following patch remove your Oops?

Looking at the init code I agree. Yes, the patch fixes the OOPS. I am sure
because the OOPS occurred at every boot and now it's gone.

Thanks!

Ortwin

> 
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c
> b/drivers/net/wireless/ath/ath9k/recv.c
> index ca6065b..e3e5291 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -844,9 +844,9 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
>  	int dma_type;
> 
>  	if (edma)
> -		dma_type = DMA_FROM_DEVICE;
> -	else
>  		dma_type = DMA_BIDIRECTIONAL;
> +	else
> +		dma_type = DMA_FROM_DEVICE;
> 
>  	qtype = hp ? ATH9K_RX_QUEUE_HP : ATH9K_RX_QUEUE_LP;
>  	spin_lock_bh(&sc->rx.rxbuflock);
> 

  reply	other threads:[~2010-07-23 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14  6:54 BUG at arch/x86/mm/physaddr.c:5 Ortwin Glück
2010-07-23  8:04 ` Jike Song
2010-07-23 13:51   ` Ortwin Glück [this message]
2010-07-26  6:13     ` Jike Song
2010-07-26 16:55       ` Luis R. Rodriguez
2010-07-26 17:22         ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C499E6F.8030507@odi.ch \
    --to=odi@odi.ch \
    --cc=albcamus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=vasanth@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox