From: Yinghai Lu <yinghai@kernel.org>
To: Don Zickus <dzickus@redhat.com>
Cc: fweisbec@gmail.com, peterz@infradead.org, mingo@elte.hu,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] x86: perf swallows all NMIs when registered with a user
Date: Fri, 23 Jul 2010 09:42:18 -0700 [thread overview]
Message-ID: <4C49C66A.3000002@kernel.org> (raw)
In-Reply-To: <20100723125505.GQ7330@redhat.com>
On 07/23/2010 05:55 AM, Don Zickus wrote:
> On Thu, Jul 22, 2010 at 03:58:21PM -0700, Yinghai Lu wrote:
>> cool, with your patch and following patch i can use nmi button now with CONFIG_LOCKUP_DETECTOR defined
>>
>> [PATCH] x86,nmi: move unknown_nmi_panic to traps.c
>>
>> So we use it even LOCKUP_DETECTOR is defined.
>>
>> need Don's patch...
>
> Thanks for the feedback Yinghai!
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> With regards to your patch, I am still a little uncomfortable with it, as
> it seems to be redundant with what is used in unknown_nmi_error() and the
> panic_on_unrecovered_nmi flag. I agree that keeping the familiar flag
> 'unknown_nmi_panic' is needed. But I was still wondering if wrapping it
> around 'panic_on_unrecovered_nmi' would be simpler and less code.
how about the one in sysctl?
Thanks
Yinghai
next prev parent reply other threads:[~2010-07-23 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 21:51 [RFC] x86: perf swallows all NMIs when registered with a user Don Zickus
2010-07-22 22:58 ` Yinghai Lu
2010-07-23 12:55 ` Don Zickus
2010-07-23 16:42 ` Yinghai Lu [this message]
2010-07-23 17:10 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C49C66A.3000002@kernel.org \
--to=yinghai@kernel.org \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox