Re: [PATCH wq#for-next] fscache: fix build on !CONFIG_SYSCTL

Randy Dunlap
2010-07-25T22:20:42Z

On 07/24/10 02:14, Tejun Heo wrote:
> Commit 8b8edefa (fscache: convert object to use workqueue instead of
> slow-work) made fscache_exit() call unregister_sysctl_table()
> unconditionally breaking build when sysctl is disabled. Fix it by
> putting it inside CONFIG_SYSCTL.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: David Howells <dhowells@redhat.com>
> ---
> This should fix it. Thanks.

Ack. Thanks.

>
> fs/fscache/main.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fscache/main.c b/fs/fscache/main.c
> index 500936d..f9d8567 100644
> --- a/fs/fscache/main.c
> +++ b/fs/fscache/main.c
> @@ -186,7 +186,9 @@ static void __exit fscache_exit(void)
>
> kobject_put(fscache_root);
> kmem_cache_destroy(fscache_cookie_jar);
> +#ifdef CONFIG_SYSCTL
> unregister_sysctl_table(fscache_sysctl_header);
> +#endif
> fscache_proc_cleanup();
> destroy_workqueue(fscache_op_wq);
> destroy_workqueue(fscache_object_wq);

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***