* [PATCH] x86, mrst: remove unused mrst_identify_cpu()
@ 2010-07-25 4:50 Javier Martinez Canillas
2010-07-25 5:04 ` H. Peter Anvin
2010-07-25 10:54 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2010-07-25 4:50 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Jacob Pan,
Feng Tang, linux-kernel
mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
arch/x86/include/asm/mrst.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h
index 1635074..0d0e702 100644
--- a/arch/x86/include/asm/mrst.h
+++ b/arch/x86/include/asm/mrst.h
@@ -26,10 +26,6 @@ enum mrst_cpu_type {
};
extern enum mrst_cpu_type __mrst_cpu_chip;
-static enum mrst_cpu_type mrst_identify_cpu(void)
-{
- return __mrst_cpu_chip;
-}
enum mrst_timer_options {
MRST_TIMER_DEFAULT,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()
2010-07-25 4:50 [PATCH] x86, mrst: remove unused mrst_identify_cpu() Javier Martinez Canillas
@ 2010-07-25 5:04 ` H. Peter Anvin
2010-07-25 10:55 ` Alan Cox
2010-07-25 10:54 ` Alan Cox
1 sibling, 1 reply; 5+ messages in thread
From: H. Peter Anvin @ 2010-07-25 5:04 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Thomas Gleixner, Ingo Molnar, x86, Jacob Pan, Feng Tang,
linux-kernel
Jacob, is this obsolete or something that will be needed in future versions?
It seems that either __mrst_cpu_chip should be killed off, or read-only
users should be using the inline instead of __mrst_cpu_chip directly.
-hpa
On 07/24/2010 09:50 PM, Javier Martinez Canillas wrote:
> mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> arch/x86/include/asm/mrst.h | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h
> index 1635074..0d0e702 100644
> --- a/arch/x86/include/asm/mrst.h
> +++ b/arch/x86/include/asm/mrst.h
> @@ -26,10 +26,6 @@ enum mrst_cpu_type {
> };
>
> extern enum mrst_cpu_type __mrst_cpu_chip;
> -static enum mrst_cpu_type mrst_identify_cpu(void)
> -{
> - return __mrst_cpu_chip;
> -}
>
> enum mrst_timer_options {
> MRST_TIMER_DEFAULT,
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()
2010-07-25 5:04 ` H. Peter Anvin
@ 2010-07-25 10:55 ` Alan Cox
2010-07-25 18:56 ` H. Peter Anvin
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2010-07-25 10:55 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Javier Martinez Canillas, Thomas Gleixner, Ingo Molnar, x86,
Jacob Pan, Feng Tang, linux-kernel
On Sat, 24 Jul 2010 22:04:45 -0700
"H. Peter Anvin" <hpa@zytor.com> wrote:
> Jacob, is this obsolete or something that will be needed in future versions?
>
> It seems that either __mrst_cpu_chip should be killed off, or read-only
> users should be using the inline instead of __mrst_cpu_chip directly.
And how is the inline going to access the variable if the variable isn't
global ...
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()
2010-07-25 10:55 ` Alan Cox
@ 2010-07-25 18:56 ` H. Peter Anvin
0 siblings, 0 replies; 5+ messages in thread
From: H. Peter Anvin @ 2010-07-25 18:56 UTC (permalink / raw)
To: Alan Cox
Cc: Javier Martinez Canillas, Thomas Gleixner, Ingo Molnar, x86,
Jacob Pan, Feng Tang, linux-kernel
On 07/25/2010 03:55 AM, Alan Cox wrote:
> On Sat, 24 Jul 2010 22:04:45 -0700
> "H. Peter Anvin" <hpa@zytor.com> wrote:
>
>> Jacob, is this obsolete or something that will be needed in future versions?
>>
>> It seems that either __mrst_cpu_chip should be killed off, or read-only
>> users should be using the inline instead of __mrst_cpu_chip directly.
>
> And how is the inline going to access the variable if the variable isn't
> global ...
>
> Alan
Well, of course it needs to be global. The "or" in the above sentence
is an xor.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()
2010-07-25 4:50 [PATCH] x86, mrst: remove unused mrst_identify_cpu() Javier Martinez Canillas
2010-07-25 5:04 ` H. Peter Anvin
@ 2010-07-25 10:54 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: Alan Cox @ 2010-07-25 10:54 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Jacob Pan,
Feng Tang, linux-kernel
On Sun, 25 Jul 2010 00:50:38 -0400
Javier Martinez Canillas <martinez.javier@gmail.com> wrote:
> mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.
NAK
This is stuff being merged.
If you are going to try and remove stuff, -next is not the place to
track !
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-07-25 18:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-25 4:50 [PATCH] x86, mrst: remove unused mrst_identify_cpu() Javier Martinez Canillas
2010-07-25 5:04 ` H. Peter Anvin
2010-07-25 10:55 ` Alan Cox
2010-07-25 18:56 ` H. Peter Anvin
2010-07-25 10:54 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox