Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

H. Peter Anvin
2010-07-25T18:56:33Z

On 07/25/2010 03:55 AM, Alan Cox wrote:
> On Sat, 24 Jul 2010 22:04:45 -0700
> "H. Peter Anvin" <hpa@zytor.com> wrote:
>
>> Jacob, is this obsolete or something that will be needed in future versions?
>>
>> It seems that either __mrst_cpu_chip should be killed off, or read-only
>> users should be using the inline instead of __mrst_cpu_chip directly.
>
> And how is the inline going to access the variable if the variable isn't
> global ...
>
> Alan

Well, of course it needs to be global. The "or" in the above sentence
is an xor.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.