From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193Ab0GYWUm (ORCPT ); Sun, 25 Jul 2010 18:20:42 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:64649 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971Ab0GYWU1 (ORCPT ); Sun, 25 Jul 2010 18:20:27 -0400 Message-ID: <4C4CB841.8010804@oracle.com> Date: Sun, 25 Jul 2010 15:18:41 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Tejun Heo CC: Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH wq#for-next] fscache: fix build on !CONFIG_SYSCTL References: <20100723164931.7bf2160f.sfr@canb.auug.org.au> <20100723090831.6af4a288.randy.dunlap@oracle.com> <4C4AAEE9.8050903@kernel.org> In-Reply-To: <4C4AAEE9.8050903@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4C4CB8A2.0003:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24/10 02:14, Tejun Heo wrote: > Commit 8b8edefa (fscache: convert object to use workqueue instead of > slow-work) made fscache_exit() call unregister_sysctl_table() > unconditionally breaking build when sysctl is disabled. Fix it by > putting it inside CONFIG_SYSCTL. > > Signed-off-by: Tejun Heo > Reported-by: Randy Dunlap > Cc: David Howells > --- > This should fix it. Thanks. Ack. Thanks. > > fs/fscache/main.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/fscache/main.c b/fs/fscache/main.c > index 500936d..f9d8567 100644 > --- a/fs/fscache/main.c > +++ b/fs/fscache/main.c > @@ -186,7 +186,9 @@ static void __exit fscache_exit(void) > > kobject_put(fscache_root); > kmem_cache_destroy(fscache_cookie_jar); > +#ifdef CONFIG_SYSCTL > unregister_sysctl_table(fscache_sysctl_header); > +#endif > fscache_proc_cleanup(); > destroy_workqueue(fscache_op_wq); > destroy_workqueue(fscache_object_wq); -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***