From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443Ab0GZDpw (ORCPT ); Sun, 25 Jul 2010 23:45:52 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:60781 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753290Ab0GZDpv (ORCPT ); Sun, 25 Jul 2010 23:45:51 -0400 Message-ID: <4C4CF0EA.2080104@cn.fujitsu.com> Date: Mon, 26 Jul 2010 10:20:26 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Theodore Tso CC: KOSAKI Motohiro , Christoph Hellwig , Steven Rostedt , LKML , linux-ext4@vger.kernel.org, Frederic Weisbecker Subject: Re: [BUG] ext4 trace events cause NULL pointer dereferences References: <20100722054957.GA11670@infradead.org> <20100723011315.GC16373@thunk.org> <20100723144549.88BA.A69D9226@jp.fujitsu.com> <4E28BC9A-BB77-45BC-862A-29601EF4AE2C@mit.edu> In-Reply-To: <4E28BC9A-BB77-45BC-862A-29601EF4AE2C@mit.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Theodore Tso wrote: > On Jul 23, 2010, at 1:47 AM, KOSAKI Motohiro wrote: > >> I'm not familiar ext4 so much. but you patch seems very nice! >> thank you :) > > So, can someone confirm that this fixes the NULL pointer dereference? The patch itself makes sense, and it doesn't change the tracepoint output, so I'm inclined to include it, but I haven't been able to reproduce the failure myself using the reproduction recipe given at the beginning of this thread --- and I'd feel much better if someone who has been able to reproduce the crash can confirm this fixes things for them. > The patch works! Tested-by: Li Zefan