* Re: [patch 1/3] hpet: factor timer allocate from open
[not found] <201007202223.o6KMNDZl021345@imap1.linux-foundation.org>
@ 2010-07-23 13:07 ` Thomas Gleixner
2010-07-26 6:20 ` Clemens Ladisch
2010-07-26 20:36 ` Mag
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Gleixner @ 2010-07-23 13:07 UTC (permalink / raw)
To: akpm; +Cc: John Stultz, maglyx, clemens, LKML
On Tue, 20 Jul 2010, akpm@linux-foundation.org wrote:
> From: Magnus Lynch <maglyx@gmail.com>
>
> The current implementation of the /dev/hpet driver couples opening the
> device with allocating one of the (scarce) timers (aka comparators). This
> is a limitation in that the main counter may be valuable to applications
> seeking a high-resolution timer who have no use for the interrupt
> generating functionality of the comparators.
And how exactly does this patch provide such functionality ? There is
no interface which allows you to access the counter itself. All what
this patch does is removing the allocation from open() and sprinkle
the allocation all over the place for _ZERO_ benefit.
I really have a hard time to understand why anything would open
/dev/hpet just to do nothing with it.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 1/3] hpet: factor timer allocate from open
2010-07-23 13:07 ` [patch 1/3] hpet: factor timer allocate from open Thomas Gleixner
@ 2010-07-26 6:20 ` Clemens Ladisch
2010-07-26 20:36 ` Mag
1 sibling, 0 replies; 3+ messages in thread
From: Clemens Ladisch @ 2010-07-26 6:20 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: akpm, John Stultz, maglyx, LKML
Thomas Gleixner wrote:
> On Tue, 20 Jul 2010, akpm@linux-foundation.org wrote:
> > From: Magnus Lynch <maglyx@gmail.com>
> >
> > The current implementation of the /dev/hpet driver couples opening the
> > device with allocating one of the (scarce) timers (aka comparators). This
> > is a limitation in that the main counter may be valuable to applications
> > seeking a high-resolution timer who have no use for the interrupt
> > generating functionality of the comparators.
>
> And how exactly does this patch provide such functionality ? There is
> no interface which allows you to access the counter itself.
Through mmap(); this is the only interface of /dev/hpet that is actually
used in practice.
> Cc: Clemens Ladisch <clemens@ladisch.de>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Regards,
Clemens
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 1/3] hpet: factor timer allocate from open
2010-07-23 13:07 ` [patch 1/3] hpet: factor timer allocate from open Thomas Gleixner
2010-07-26 6:20 ` Clemens Ladisch
@ 2010-07-26 20:36 ` Mag
1 sibling, 0 replies; 3+ messages in thread
From: Mag @ 2010-07-26 20:36 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: akpm, John Stultz, clemens, LKML
On Fri, Jul 23, 2010 at 6:07 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> And how exactly does this patch provide such functionality ? There is
> no interface which allows you to access the counter itself.
Yes there is, mmap allows you access the registers.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-26 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201007202223.o6KMNDZl021345@imap1.linux-foundation.org>
2010-07-23 13:07 ` [patch 1/3] hpet: factor timer allocate from open Thomas Gleixner
2010-07-26 6:20 ` Clemens Ladisch
2010-07-26 20:36 ` Mag
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox