From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Corey Minyard <minyard@acm.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Garrett <mjg@redhat.com>, Len Brown <len.brown@intel.com>,
Myron Stowe <myron.stowe@hp.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Fix ACPI detecting with regspacing
Date: Tue, 27 Jul 2010 10:28:28 -0700 [thread overview]
Message-ID: <4C4F173C.1010406@kernel.org> (raw)
In-Reply-To: <201007271123.44335.bjorn.helgaas@hp.com>
On 07/27/2010 10:23 AM, Bjorn Helgaas wrote:
> On Tuesday, July 27, 2010 11:07:55 am Yinghai Lu wrote:
>> On 07/27/2010 08:34 AM, Bjorn Helgaas wrote:
>>> On Monday, July 26, 2010 03:48:02 pm Yinghai Lu wrote:
>>>>
>>>> after the commint that change ipmi_si detecting sequence from SMBIOS/ACPI to ACPI/SMBIOS,
>>>>
>>>> | commit 754d453185275951d39792865927ec494fa1ebd8
>>>> | Author: Matthew Garrett <mjg@redhat.com>
>>>> | Date: Wed May 26 14:43:47 2010 -0700
>>>> |
>>>> | ipmi: change device discovery order
>>>> |
>>>> | The ipmi spec provides an ordering for si discovery. Change the driver to
>>>> | match, with the exception of preferring smbios to SPMI as HPs (at least)
>>>> | contain accurate information in the former but not the latter.
>>>>
>>>> ipmi_si can not be initialized.
>>>
>>> I think this patch makes sense, as long as this is not a bringup
>>> issue that only affects pre-release firmware. If this only affects
>>> a prototype, it would be better to change the firmware so it conforms
>>> to the conventional _CRS usage of systems in the field.
>>>
>>> To that end, I'd like to know what system this is, and whether IPMI
>>> works under Windows on this system. We know that Windows doesn't
>>> look at SMBIOS or SPMI, so if Windows works, it must be doing something
>>> similar to your patch.
>>
>> Sun Fire X4800.
>>
>> Yes. other OSes work and pass certification.
>
> Please put this information in the changelog (if that wasn't obvious).
>
I don't want to mention other os.
Yinghai
next prev parent reply other threads:[~2010-07-27 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 21:48 [PATCH] ipmi: Fix ACPI detecting with regspacing Yinghai Lu
2010-07-26 21:57 ` Matthew Garrett
2010-07-27 15:34 ` Bjorn Helgaas
2010-07-27 17:07 ` Yinghai Lu
2010-07-27 17:23 ` Bjorn Helgaas
2010-07-27 17:28 ` Yinghai Lu [this message]
2010-07-27 17:41 ` Bjorn Helgaas
2010-07-28 19:22 ` Andrew Morton
2010-07-28 19:31 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4F173C.1010406@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=mjg@redhat.com \
--cc=myron.stowe@hp.com \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox