Re: [PATCH 9/9] x86: Detect whether we should use Xen SWIOTLB.

["H. Peter Anvin" <hpa@zytor.com>]

On 07/27/2010 04:36 PM, FUJITA Tomonori wrote:
>>>
>>> Is there any way we can abstract this out a bit more instead of crapping
>>> on generic code?
> 
> I don't like this change much too, however I think that this is the
> most simple and straightforward.
> 
> Basically, Xen's swiotlb works like a new IOMMU implementation so we
> need to initialize it like other IOMMU implementations (call the
> detect and init functions in order).
> 

Even mentioning "xen" in generic code should be considered a bug.  I
think we *do* need to driverize the iommu stuff, and yes, Xen's swiotlb
should just be handled like one in the list.

> 
>> I was toying with something like this:
>>
>> diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
>> index 9f07cfc..e0cd388 100644
>> --- a/arch/x86/kernel/pci-dma.c
>> +++ b/arch/x86/kernel/pci-dma.c
>> @@ -45,6 +45,25 @@ int iommu_detected __read_mostly = 0;
>>   */
>>  int iommu_pass_through __read_mostly;
>>  
>> +initcall_t __swiotlb_initcall_detect[] =
>> +	{pci_xen_swiotlb_detect,
>> +	 pci_swiotlb_detect,
>> +	NULL};
>> +
>> +initcall_t __swiotlb_initcall_init[] = {
>> +	pci_xen_swiotlb_init,
>> +	pci_swiotlb_init,
>> +	NULL};
>> +
>> +
>> +initcall_t __iommu_initcall_detect[] = {
>> +	gart_iommu_hole_init,
>> +	detect_calgary,
>> +	detect_intel_iommu,
>> +	/* needs to be called after gart_iommu_hole_init */
>> +	amd_iommu_detect,
>> +	NULL};
> 
> I really don't think that this makes the code better. I prefer the
> current simple (dumb) code.
> 

The special handling of swiotlb here really looks wrong, but otherwise I
think it's the right idea.

> btw, this comment is wrong. We check if we are forced to use SWIOTLB
> by kernel command line here.
> 
> Even if SWIOTLB works, we see if hardware IOMMU is available. SWIOTLB
> is a last resort. We prefer hardware IOMMU.

Any reason to not just handle swiotlb like any of the other iommus, at
the bottom of the list?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.