Re: [RFC][PATCH] PCI / PCIe: Ask BIOS for control of all native services simultaneously

Hidetoshi Seto
2010-07-28T03:40:20Z

Hi,

(2010/07/25 8:05), Rafael J. Wysocki wrote:
> It turns out that asking ACPI BIOS, through _OSC, for control of each
> PCIe port native service individually sometimes confuses the BIOS if
> one sevice is requested while the others are not (eg. requesting
> control of the native PCIe PME without requesting control of the
> native PCIe hot-plug at the same time leads to interrupt storms on
> some systems).

Then why not invent quirks or something for such systems?

IMHO it sounds like a BIOS bug since it should grant PME control to
OS only when both of PME and pciehp (plus PCIe caps) are requested
at same time.

Did you confirm that the system also confuses when pciehp is requested
without requesting PME?
e.g. assume that some BIOS might behave:
_OSC(pciehp) => OK
_OSC(PME) => NG (bugs on shared interrupt?)
_OSC(pciehp|PME) => OK
_OSC(SHPC) => OK
_OSC(pciehp|SHPC) => NG (must choose one, not both)
_OSC(AER|SHPC) => OK

I don't doubt that handling of _OSC needs some improvement...

Thanks,
H.Seto