From: Arjan van de Ven <arjan@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Patrick Pannuto <ppannuto@codeaurora.org>,
linux-kernel@vger.kernel.org, apw@canonical.com, corbet@lwn.net,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH 1/4] timer: Added usleep[_range] timer
Date: Wed, 28 Jul 2010 14:04:47 -0700 [thread overview]
Message-ID: <4C509B6F.8000200@linux.intel.com> (raw)
In-Reply-To: <20100728135857.2a0ab8bd.akpm@linux-foundation.org>
On 7/28/2010 1:58 PM, Andrew Morton wrote:
>
> My main concern is that someone will type usleep(50) and won't realise
> that it goes and sleeps for 100 usecs and their code gets slow as a
> result. This sort of thing takes *years* to discover and fix. If we'd
> forced them to type usleep_range() instead, it would never have happened.
>
>
>
> Another question: what is the typical overhead of a usleep()? IOW, at
> what delay value does it make more sense to use udelay()? Another way
> of asking that would be "how long does a usleep(1) take"? If it
> reliably consumes 2us CPU time then we shouldn't do it.
>
> But it's not just CPU time, is it? A smart udelay() should put the CPU
> into a lower power state, so a udelay(3) might consume less energy than
> a usleep(2), because the usleep() does much more work in schedule() and
> friends?
>
for very low values of udelay() you're likely right.... but we could and
should catch that inside usleep imo and fall back to a udelay
it'll likely be 10 usec or so where we'd cut off.
now there is no such thing as a "low power udelay", not really anyway....
but the opposite is true; the cpu idle code will effectively do the
equivalent of udelay() if you're asking for a very short delay, so
short that any power saving thing isn't giong to be worth it. ( +
hitting scheduler overhead
next prev parent reply other threads:[~2010-07-28 21:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 19:33 [PATCH v2 0/4] timer: Added usleep[_range] timer Patrick Pannuto
2010-07-28 19:33 ` [PATCH 1/4] " Patrick Pannuto
2010-07-28 20:23 ` Andrew Morton
2010-07-28 20:47 ` Patrick Pannuto
2010-07-28 20:58 ` Andrew Morton
2010-07-28 21:04 ` Arjan van de Ven [this message]
2010-07-28 21:11 ` Patrick Pannuto
2010-07-28 21:22 ` Andrew Morton
2010-07-28 21:25 ` Arjan van de Ven
2010-07-28 21:05 ` Patrick Pannuto
2010-07-28 21:23 ` Andrew Morton
2010-07-28 21:26 ` Arjan van de Ven
2010-07-28 19:33 ` [PATCH 2/4] Documentation: Add timers/timers-howto.txt Patrick Pannuto
2010-07-28 19:33 ` [PATCH 3/4] Checkpatch: prefer usleep over udelay Patrick Pannuto
2010-07-28 20:24 ` Andrew Morton
2010-07-28 19:33 ` [PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's Patrick Pannuto
2010-07-28 20:24 ` Andrew Morton
2010-07-28 20:48 ` Patrick Pannuto
2010-08-03 19:12 ` [PATCH v2 0/4] timer: Added usleep[_range] timer Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C509B6F.8000200@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ppannuto@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox