From: Jiri Slaby <jirislaby@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"ss@aao.gov.au" <ss@aao.gov.au>,
"gregkh@suse.de" <gregkh@suse.de>
Subject: Re: [PATCH] Staging: dt3155: properly export the module parameter
Date: Thu, 29 Jul 2010 15:09:20 +0200 [thread overview]
Message-ID: <4C517D80.6010106@gmail.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269763743B4D7C@AUSP01VMBX24.collaborationhost.net>
On 07/29/2010 02:55 AM, H Hartley Sweeten wrote:
> On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote:
>> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote:
>>> --- a/drivers/staging/dt3155/dt3155_drv.c
>>> +++ b/drivers/staging/dt3155/dt3155_drv.c
>>> @@ -99,7 +99,9 @@ wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS];
>>>
>>> /* set to dynamicaly allocate, but it is tunable: */
>>> /* insmod DT_3155 dt3155 dt3155_major=XX */
>>> -int dt3155_major = 0;
>>> +static int dt3155_major;
>>> +module_param(dt3155_major, int, 0);
>>> +MODULE_PARM_DESC(dt3155_major, "Major device number");
>>
>> Is it necessary in the age of udev?
>>
>> I would personally get rid of that completely...
>
> I agree but I'm not quite sure if the user space app is ready to handle that.
Given it was never exposed as a parameter, applications should handle
that. 0 means allocate major dynamically...
regards,
--
js
next prev parent reply other threads:[~2010-07-29 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 16:48 [PATCH] Staging: dt3155: properly export the module parameter H Hartley Sweeten
2010-07-28 20:59 ` Jiri Slaby
2010-07-29 0:55 ` H Hartley Sweeten
2010-07-29 13:09 ` Jiri Slaby [this message]
2010-07-29 16:02 ` H Hartley Sweeten
2010-08-03 1:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C517D80.6010106@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ss@aao.gov.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox