From: Milan Broz <mbroz@redhat.com>
To: Karel Zak <kzak@redhat.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
util-linux-ng@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk
Subject: Re: [PATCH] loop: add some basic read-only sysfs attributes
Date: Thu, 29 Jul 2010 22:24:15 +0200 [thread overview]
Message-ID: <4C51E36F.6060906@redhat.com> (raw)
In-Reply-To: <20100729195616.GF1981@nb.net.home>
On 07/29/2010 09:56 PM, Karel Zak wrote:
>> Sure it does. Sysfs attributes need to be created _before_ uevents are
>> sent out. The current behavior is that all blockdev attributes are
>> safely created before the event is sent. These loop attributes are
>> created _after_ the event is sent.
>>
>> The question is if we can rely on the fact, that 'add' events never
>> want to look at any of these attributes, and all can be deferred to
The problem is that add_disk() initializes kobject and announces device.
How can I add some new attributes (subdir) with the current code
before it happens?
And why it is problem at all? After configuration there is always change
event and at this time attributes are there.
Milan
next prev parent reply other threads:[~2010-07-29 20:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100722101541.GU15652@nb.net.home>
2010-07-29 13:33 ` [PATCH] loop: add some basic read-only sysfs attributes Milan Broz
2010-07-29 13:47 ` Kay Sievers
2010-07-29 14:06 ` Milan Broz
2010-07-29 14:22 ` Kay Sievers
2010-07-29 14:35 ` Milan Broz
2010-07-29 14:58 ` Karel Zak
2010-07-29 16:07 ` Kay Sievers
2010-07-29 19:56 ` Karel Zak
2010-07-29 20:06 ` Karel Zak
2010-07-29 20:24 ` Milan Broz [this message]
2010-07-30 4:36 ` Kay Sievers
2010-07-30 14:22 ` [PATCH v2] " Milan Broz
2010-07-30 14:34 ` Kay Sievers
2010-08-23 12:29 ` Karel Zak
2010-08-23 12:30 ` Jens Axboe
2010-07-30 7:37 ` [PATCH] " Karel Zak
2010-07-30 7:43 ` Kay Sievers
2010-07-30 8:01 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C51E36F.6060906@redhat.com \
--to=mbroz@redhat.com \
--cc=axboe@kernel.dk \
--cc=kay.sievers@vrfy.org \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=util-linux-ng@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox