* [PATCH 2/9] staging: octeon: check request_irq() return value
@ 2010-07-30 11:07 Kulikov Vasiliy
2010-07-30 15:19 ` David Daney
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-30 11:07 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Ralf Baechle, David Daney, devel,
linux-kernel
request_irq() may fail, if so propagate error code.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/octeon/ethernet-spi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-spi.c b/drivers/staging/octeon/ethernet-spi.c
index b58b897..9708254 100644
--- a/drivers/staging/octeon/ethernet-spi.c
+++ b/drivers/staging/octeon/ethernet-spi.c
@@ -294,6 +294,8 @@ int cvm_oct_spi_init(struct net_device *dev)
if (number_spi_ports == 0) {
r = request_irq(OCTEON_IRQ_RML, cvm_oct_spi_rml_interrupt,
IRQF_SHARED, "SPI", &number_spi_ports);
+ if (r)
+ return r;
}
number_spi_ports++;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/9] staging: octeon: check request_irq() return value
2010-07-30 11:07 [PATCH 2/9] staging: octeon: check request_irq() return value Kulikov Vasiliy
@ 2010-07-30 15:19 ` David Daney
0 siblings, 0 replies; 2+ messages in thread
From: David Daney @ 2010-07-30 15:19 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Ralf Baechle, devel,
linux-kernel
On 07/30/2010 04:07 AM, Kulikov Vasiliy wrote:
> request_irq() may fail, if so propagate error code.
>
> Signed-off-by: Kulikov Vasiliy<segooon@gmail.com>
You can add:
Acked-by: David Daney <ddaney@caviumnetworks.com>
> ---
> drivers/staging/octeon/ethernet-spi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-spi.c b/drivers/staging/octeon/ethernet-spi.c
> index b58b897..9708254 100644
> --- a/drivers/staging/octeon/ethernet-spi.c
> +++ b/drivers/staging/octeon/ethernet-spi.c
> @@ -294,6 +294,8 @@ int cvm_oct_spi_init(struct net_device *dev)
> if (number_spi_ports == 0) {
> r = request_irq(OCTEON_IRQ_RML, cvm_oct_spi_rml_interrupt,
> IRQF_SHARED, "SPI",&number_spi_ports);
> + if (r)
> + return r;
> }
> number_spi_ports++;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-30 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-30 11:07 [PATCH 2/9] staging: octeon: check request_irq() return value Kulikov Vasiliy
2010-07-30 15:19 ` David Daney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox