From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755017Ab0GaSua (ORCPT ); Sat, 31 Jul 2010 14:50:30 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:48138 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753792Ab0GaSu2 (ORCPT ); Sat, 31 Jul 2010 14:50:28 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=k0Io8c7JqUhN/mK7YjNWPNl1AwOav2gb4ba5r8O631F9KyBxvAswbQF395eCNxVY+u YRjPo66nlpFjH5L6vMuMMSlN4EMAra74I+PYUViC45jw2AjDiuoIENPR8aNDRl5ltpIP npyZgFaVjUC6U17YOaCLdxx1VAlnzd+oSMv+4= Message-ID: <4C54707B.4040008@gmail.com> Date: Sat, 31 Jul 2010 11:50:35 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100615 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: "Justin P. Mattock" CC: linux-acpi@vger.kernel.org, lenb@kernel.org, dhowells@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH]acpi:glue.c Fix warning: variable 'ret' set but not used References: <1278033261-2733-1-git-send-email-justinmattock@gmail.com> In-Reply-To: <1278033261-2733-1-git-send-email-justinmattock@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org whats going on with this patch? havent heard anything on this. > Fix a warning message generated by gcc: > CC drivers/acpi/glue.o > drivers/acpi/glue.c: In function 'acpi_bind_one': > drivers/acpi/glue.c:163:7: warning: variable 'ret' set but not used > > Signed-off-by: Justin P. Mattock > Signed-off-by: David Howells > > --- > drivers/acpi/glue.c | 14 +++++++++++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c > index 4af6301..23b16e6 100644 > --- a/drivers/acpi/glue.c > +++ b/drivers/acpi/glue.c > @@ -145,6 +145,7 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) > { > struct acpi_device *acpi_dev; > acpi_status status; > + int fn, pn; > > if (dev->archdata.acpi_handle) { > dev_warn(dev, "Drivers changed 'acpi_handle'\n"); > @@ -160,12 +161,19 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) > > status = acpi_bus_get_device(handle,&acpi_dev); > if (!ACPI_FAILURE(status)) { > - int ret; > > - ret = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj, > + fn = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj, > "firmware_node"); > - ret = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj, > + pn = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj, > "physical_node"); > + if (fn || pn) { > + dev_warn(&acpi_dev->dev, > + "Failed to create link(s) to %s %s:" > + " %d\n", > + dev_driver_string(dev), dev_name(dev), > + fn ?: pn); > + return AE_ERROR; > + } > if (acpi_dev->wakeup.flags.valid) { > device_set_wakeup_capable(dev, true); > device_set_wakeup_enable(dev,