public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org
Subject: Re: [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used
Date: Sat, 31 Jul 2010 12:04:11 -0700	[thread overview]
Message-ID: <4C5473AB.709@gmail.com> (raw)
In-Reply-To: <1278969866-25191-1-git-send-email-justinmattock@gmail.com>

haven't heard anything on this.. is this in the vicinity of being a 
right solution?

> Not sure if this is the right approach with this.. The below
> fixes a warning message generated by GCC
>    CC      kernel/irq/manage.o
> kernel/irq/manage.c: In function '__setup_irq':
> kernel/irq/manage.c:652:14: warning: variable 'old_name' set but not used
>
> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> ---
>   kernel/irq/manage.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e149748..99d2f39 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -733,6 +733,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
>   		if (!((old->flags&  new->flags)&  IRQF_SHARED) ||
>   		    ((old->flags ^ new->flags)&  IRQF_TRIGGER_MASK)) {
>   			old_name = old->name;
> +			if(old_name) {
> +				printk(KERN_ERR "IRQ mismatch: %d %s\n", IRQF_SHARED, old_name);
> +			}	
>   			goto mismatch;
>   		}
>


      reply	other threads:[~2010-07-31 19:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 21:24 [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used Justin P. Mattock
2010-07-31 19:04 ` Justin P. Mattock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5473AB.709@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox