* [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used
@ 2010-07-12 21:24 Justin P. Mattock
2010-07-31 19:04 ` Justin P. Mattock
0 siblings, 1 reply; 2+ messages in thread
From: Justin P. Mattock @ 2010-07-12 21:24 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, peterz, Justin P. Mattock
Not sure if this is the right approach with this.. The below
fixes a warning message generated by GCC
CC kernel/irq/manage.o
kernel/irq/manage.c: In function '__setup_irq':
kernel/irq/manage.c:652:14: warning: variable 'old_name' set but not used
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
kernel/irq/manage.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index e149748..99d2f39 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -733,6 +733,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
if (!((old->flags & new->flags) & IRQF_SHARED) ||
((old->flags ^ new->flags) & IRQF_TRIGGER_MASK)) {
old_name = old->name;
+ if(old_name) {
+ printk(KERN_ERR "IRQ mismatch: %d %s\n", IRQF_SHARED, old_name);
+ }
goto mismatch;
}
--
1.7.1.rc1.21.gf3bd6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used
2010-07-12 21:24 [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used Justin P. Mattock
@ 2010-07-31 19:04 ` Justin P. Mattock
0 siblings, 0 replies; 2+ messages in thread
From: Justin P. Mattock @ 2010-07-31 19:04 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: linux-kernel, tglx, peterz
haven't heard anything on this.. is this in the vicinity of being a
right solution?
> Not sure if this is the right approach with this.. The below
> fixes a warning message generated by GCC
> CC kernel/irq/manage.o
> kernel/irq/manage.c: In function '__setup_irq':
> kernel/irq/manage.c:652:14: warning: variable 'old_name' set but not used
>
> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> ---
> kernel/irq/manage.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e149748..99d2f39 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -733,6 +733,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
> if (!((old->flags& new->flags)& IRQF_SHARED) ||
> ((old->flags ^ new->flags)& IRQF_TRIGGER_MASK)) {
> old_name = old->name;
> + if(old_name) {
> + printk(KERN_ERR "IRQ mismatch: %d %s\n", IRQF_SHARED, old_name);
> + }
> goto mismatch;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-31 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-12 21:24 [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used Justin P. Mattock
2010-07-31 19:04 ` Justin P. Mattock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox