From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755392Ab0GaTEI (ORCPT ); Sat, 31 Jul 2010 15:04:08 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:40169 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753792Ab0GaTEG (ORCPT ); Sat, 31 Jul 2010 15:04:06 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=nDHQ9NMIbQlsT/mXDsmfHzAhGNOa71KzogmRNtUrb4f8atQfiukwRW7YXFyVVzhB1p H0spJBXRdKuO9mvgA7mFqY2aLPXpVFHQhtH9M32LcL2x6Hu5lmx6OlI+ydUmCfZgUVfs Nw3KOvSTaUzidd6geb5WDcXVShvx83SdqFHB8= Message-ID: <4C5473AB.709@gmail.com> Date: Sat, 31 Jul 2010 12:04:11 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100615 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: "Justin P. Mattock" CC: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org Subject: Re: [PATCH]irq:manage.c Fix warning: variable 'old_name' set but not used References: <1278969866-25191-1-git-send-email-justinmattock@gmail.com> In-Reply-To: <1278969866-25191-1-git-send-email-justinmattock@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org haven't heard anything on this.. is this in the vicinity of being a right solution? > Not sure if this is the right approach with this.. The below > fixes a warning message generated by GCC > CC kernel/irq/manage.o > kernel/irq/manage.c: In function '__setup_irq': > kernel/irq/manage.c:652:14: warning: variable 'old_name' set but not used > > Signed-off-by: Justin P. Mattock > > --- > kernel/irq/manage.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index e149748..99d2f39 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -733,6 +733,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) > if (!((old->flags& new->flags)& IRQF_SHARED) || > ((old->flags ^ new->flags)& IRQF_TRIGGER_MASK)) { > old_name = old->name; > + if(old_name) { > + printk(KERN_ERR "IRQ mismatch: %d %s\n", IRQF_SHARED, old_name); > + } > goto mismatch; > } >