From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755703Ab0GaTE4 (ORCPT ); Sat, 31 Jul 2010 15:04:56 -0400 Received: from mail-px0-f174.google.com ([209.85.212.174]:44538 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754914Ab0GaTEy (ORCPT ); Sat, 31 Jul 2010 15:04:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=csFS+EOYnTAis7HN4WCDDsDsgCLMECbSt9QsvDFKloXsx2SrBeObIYILduN3wW41/g 4dk1S2tXgO49mCluWf/Tj64cxdMx0F/L11qa+qLo40dKortd48RRTLGlwaph6zHI+6Ir hEbemksQHQ3CSafOmg07VJ4nUOb6EnUlU7Y2I= Message-ID: <4C5473E0.308@gmail.com> Date: Sat, 31 Jul 2010 12:05:04 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100615 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: "Justin P. Mattock" CC: dm-devel@redhat.com, neilb@suse.de, agk@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]md:dm.c Fix warning: statement with no effect References: <1278984400-8837-1-git-send-email-justinmattock@gmail.com> In-Reply-To: <1278984400-8837-1-git-send-email-justinmattock@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org haven't heard any feedback on this any ideas? > Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below) > CC drivers/md/dm.o > drivers/md/dm.c: In function 'split_bvec': > drivers/md/dm.c:1117:3: warning: statement with no effect > drivers/md/dm.c: In function 'clone_bio': > drivers/md/dm.c:1145:3: warning: statement with no effect > > adding in some #ifdef's fixes this warning if someone chooses not to have > CONFIG_BLK_DEV_INTEGRITY turned on. but keep in mind not sure if this is the best approach > i.e. should something be done in bio.h? > Also this patch fixes a comment which was hard to read at first. Anyways have a look > when you have time, and let me know. > > Signed-off-by: Justin P. Mattock > > --- > drivers/md/dm.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/drivers/md/dm.c b/drivers/md/dm.c > index d21e128..7c1cb04 100644 > --- a/drivers/md/dm.c > +++ b/drivers/md/dm.c > @@ -1091,7 +1091,7 @@ static void dm_bio_destructor(struct bio *bio) > } > > /* > - * Creates a little bio that is just does part of a bvec. > + * Create a little bio that just does part of a bvec. > */ > static struct bio *split_bvec(struct bio *bio, sector_t sector, > unsigned short idx, unsigned int offset, > @@ -1114,7 +1114,9 @@ static struct bio *split_bvec(struct bio *bio, sector_t sector, > clone->bi_flags |= 1<< BIO_CLONED; > > if (bio_integrity(bio)) { > +#ifdef CONFIG_BLK_DEV_INTEGRITY > bio_integrity_clone(clone, bio, GFP_NOIO, bs); > +#endif > bio_integrity_trim(clone, > bio_sector_offset(bio, idx, offset), len); > } > @@ -1142,7 +1144,9 @@ static struct bio *clone_bio(struct bio *bio, sector_t sector, > clone->bi_flags&= ~(1<< BIO_SEG_VALID); > > if (bio_integrity(bio)) { > +#ifdef CONFIG_BLK_DEV_INTEGRITY > bio_integrity_clone(clone, bio, GFP_NOIO, bs); > +#endif > > if (idx != bio->bi_idx || clone->bi_size< bio->bi_size) > bio_integrity_trim(clone,