From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175Ab0GaTNp (ORCPT ); Sat, 31 Jul 2010 15:13:45 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:40504 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755553Ab0GaTNn (ORCPT ); Sat, 31 Jul 2010 15:13:43 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=AR4faHa5rvalHf0+nQkn+XQMS67ImYFFixGQdmyBtGYgRLCRlvu/956Vd7wpnxgvgz kGHjJjfaBmpABmYfZi+iCsVY7KwqZjyCfdXrQ9Tqn1RGxDu47J5jLfqpixrt81ghb4qf RW/kVWbg2klsxvFahHmfp7DHZNbsgxs/LjrE4= Message-ID: <4C5475F0.90104@gmail.com> Date: Sat, 31 Jul 2010 12:13:52 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100615 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: dm-devel@redhat.com, neilb@suse.de, agk@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]md:dm.c Fix warning: statement with no effect References: <1278984400-8837-1-git-send-email-justinmattock@gmail.com> <4C5473E0.308@gmail.com> <20100731190757.GC9734@agk-dp.fab.redhat.com> In-Reply-To: <20100731190757.GC9734@agk-dp.fab.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/31/2010 12:07 PM, Alasdair G Kergon wrote: > On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote: >> haven't heard any feedback on this any ideas? >>> Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below) >>> CC drivers/md/dm.o >>> drivers/md/dm.c: In function 'split_bvec': >>> drivers/md/dm.c:1117:3: warning: statement with no effect >>> drivers/md/dm.c: In function 'clone_bio': >>> drivers/md/dm.c:1145:3: warning: statement with no effect > > I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs > throughout the code. > > Alasdair > > cool thanks.. I'll have a look and see if I can come up with something. Justin P. Mattock