From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Tony Lindgren <tony@atomide.com>,
Cory Maccarrone <darkstar6262@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] usb: omap_udc: check return value of proc_create()
Date: Sun, 01 Aug 2010 14:06:38 +0400 [thread overview]
Message-ID: <4C55472E.6000307@ru.mvista.com> (raw)
In-Reply-To: <1280597965-8525-1-git-send-email-segooon@gmail.com>
Hello.
Kulikov Vasiliy wrote:
> proc_create() may fail, if so return -ENOMEM.
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
[...]
> diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
> index f81e4f0..1083216 100644
> --- a/drivers/usb/gadget/omap_udc.c
> +++ b/drivers/usb/gadget/omap_udc.c
> @@ -2544,9 +2544,9 @@ static const struct file_operations proc_ops = {
> .release = single_release,
> };
>
> -static void create_proc_file(void)
> +static int create_proc_file(void)
> {
> - proc_create(proc_filename, 0, NULL, &proc_ops);
> + return (proc_create(proc_filename, 0, NULL, &proc_ops) == NULL);
Parens not needed around the *return* expression.
WBR, Sergei
next prev parent reply other threads:[~2010-08-01 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 17:39 [PATCH 5/7] usb: omap_udc: check return value of proc_create() Kulikov Vasiliy
2010-08-01 10:06 ` Sergei Shtylyov [this message]
2010-08-01 11:29 ` Remove me!!!! Yehuda Mor
2010-08-01 12:46 ` Valeo de Vries
2010-08-01 15:16 ` trapDoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C55472E.6000307@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=darkstar6262@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox