From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/3] KVM: MMU: mark page dirty only when page is really written
Date: Mon, 02 Aug 2010 10:50:59 +0300 [thread overview]
Message-ID: <4C5678E3.8090309@redhat.com> (raw)
In-Reply-To: <4C4E53F7.7050108@cn.fujitsu.com>
On 07/27/2010 06:35 AM, Xiao Guangrong wrote:
> Mark page dirty only when this page is really written, it's more exacter,
> and also can fix dirty page marking in speculation path
>
> Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> ---
> arch/x86/kvm/mmu.c | 47 ++++++++++++++++++++++++++++-------------------
> 1 files changed, 28 insertions(+), 19 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index dd6c192..bcc2173 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -311,24 +311,42 @@ static bool spte_bits_lost(u64 spte)
> if (!is_shadow_present_pte(spte))
> return false;
>
> - if (spte& shadow_accessed_mask)
> + if (spte& shadow_accessed_mask&&
> + (!is_writable_pte(spte) || spte& shadow_dirty_mask))
> return false;
>
Please add parentheses around bitwise operators to reduce confusion.
The rest looks good.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-02 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 3:31 [PATCH 1/3] KVM: MMU: using kvm_set_pfn_accessed() instead of mark_page_accessed() Xiao Guangrong
2010-07-27 3:33 ` [PATCH 2/3] KVM: MMU: move bits lost judgement into a separate function Xiao Guangrong
2010-07-27 3:35 ` [PATCH 3/3] KVM: MMU: mark page dirty only when page is really written Xiao Guangrong
2010-08-02 7:50 ` Avi Kivity [this message]
2010-08-02 7:51 ` Xiao Guangrong
2010-08-02 8:15 ` [PATCH v2 " Xiao Guangrong
2010-08-02 7:41 ` [PATCH 2/3] KVM: MMU: move bits lost judgement into a separate function Avi Kivity
2010-08-02 7:50 ` Xiao Guangrong
2010-08-02 8:14 ` [PATCH v2 " Xiao Guangrong
2010-08-02 8:12 ` [PATCH v2 1/3] KVM: MMU: using kvm_set_pfn_accessed() instead of mark_page_accessed() Xiao Guangrong
2010-08-02 9:53 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5678E3.8090309@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox