From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk,
akpm@linux-foundation.org, p_gortmaker@yahoo.com,
kyungmin.park@samsung.com, m.szyprowski@samsung.com
Subject: Re: [PATCH v2 3/3] rtc: Add MAX8998 rtc driver
Date: Tue, 03 Aug 2010 11:02:12 +0900 [thread overview]
Message-ID: <4C5778A4.80002@samsung.com> (raw)
In-Reply-To: <20100803020847.58795fbd@linux.lan.towertech.it>
On 8/3/2010 9:08 AM, Alessandro Zummo wrote:
> On Mon, 02 Aug 2010 16:35:07 +0900
> Joonyoung Shim <jy0922.shim@samsung.com> wrote:
>
>> This adds support for the RTC provided by the Maxim 8998 chip. This
>> driver was tested on a GONI board by using the rtc-test application from
>> the Documentation/rtc.txt.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
>
> Seems nice. I'd add rtc_valid_tm where appropriate.
> And maybe free that irq you requested ;)
>
Right, i missed.
> pending those changes, you have my
>
> Acked-by: Alessandro Zummo <a.zummo@towertech.it>
>
>
Thanks.
prev parent reply other threads:[~2010-08-03 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 7:35 [PATCH v2 1/3] mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions Joonyoung Shim
2010-08-02 7:35 ` [PATCH v2 2/3] mfd: MAX8998: Add interrupts support Joonyoung Shim
2010-08-02 7:35 ` [PATCH v2 3/3] rtc: Add MAX8998 rtc driver Joonyoung Shim
2010-08-03 0:08 ` Alessandro Zummo
2010-08-03 2:02 ` Joonyoung Shim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5778A4.80002@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=p_gortmaker@yahoo.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox