[PATCH v3 0/3] MAX8998 changes for RTC

[PATCH v3 0/3] MAX8998 changes for RTC

[Joonyoung Shim]

Hi.

This patchset is to support the RTC provided by the Maxim 8998 chip. For
this first, needs i2c interface changes and interrupts support of
max8998 mfd driver.

Changes since v1:
 - Fix missing braces of 3/3 patch from v1 review.
 - The rest is same with v1.

Changes since v2:
 - add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
 - The rest is same with v2.

Joonyoung Shim (3):
      mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
      mfd: MAX8998: Add interrupts support
      rtc: Add MAX8998 rtc driver

 drivers/mfd/Kconfig                 |    2 +-
 drivers/mfd/Makefile                |    2 +-
 drivers/mfd/max8998-irq.c           |  255 +++++++++++++++++++++++++++++
 drivers/mfd/max8998.c               |   78 +++++++--
 drivers/regulator/max8998.c         |   17 ++-
 drivers/rtc/Kconfig                 |   10 ++
 drivers/rtc/Makefile                |    1 +
 drivers/rtc/rtc-max8998.c           |  300 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max8998-private.h |  106 +++++++++---
 include/linux/mfd/max8998.h         |   11 +-
 10 files changed, 726 insertions(+), 56 deletions(-)
 create mode 100644 drivers/mfd/max8998-irq.c
 create mode 100644 drivers/rtc/rtc-max8998.c

Re: [PATCH v3 0/3] MAX8998 changes for RTC

[Joonyoung Shim]

2010/8/6 Joonyoung Shim <jy0922.shim@samsung.com>:
> Hi.
>
> This patchset is to support the RTC provided by the Maxim 8998 chip. For
> this first, needs i2c interface changes and interrupts support of
> max8998 mfd driver.
>
> Changes since v1:
>  - Fix missing braces of 3/3 patch from v1 review.
>  - The rest is same with v1.
>
> Changes since v2:
>  - add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
>  - The rest is same with v2.
>
> Joonyoung Shim (3):
>      mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
>      mfd: MAX8998: Add interrupts support
>      rtc: Add MAX8998 rtc driver
>

Ping. Is there any feedback?

Thanks.

-- 
- Joonyoung Shim

Re: [PATCH v3 0/3] MAX8998 changes for RTC

[Andrew Morton]

On Wed, 25 Aug 2010 17:55:00 +0900
Joonyoung Shim <dofmind@gmail.com> wrote:

> 2010/8/6 Joonyoung Shim <jy0922.shim@samsung.com>:
> > Hi.
> >
> > This patchset is to support the RTC provided by the Maxim 8998 chip. For
> > this first, needs i2c interface changes and interrupts support of
> > max8998 mfd driver.
> >
> > Changes since v1:
> >  - Fix missing braces of 3/3 patch from v1 review.
> >  - The rest is same with v1.
> >
> > Changes since v2:
> >  - add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
> >  - The rest is same with v2.
> >
> > Joonyoung Shim (3):
> >      mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
> >      mfd: MAX8998: Add interrupts support
> >      rtc: Add MAX8998 rtc driver
> >
> 
> Ping. Is there any feedback?

They look good to me.  Things are pretty delayed at present as I (and
presumably others) recover from the -rc merge window..

I merged them.  Sam's acks on the MFD bits made life easier.

Re: [PATCH v3 0/3] MAX8998 changes for RTC

[Samuel Ortiz]

On Wed, Aug 25, 2010 at 12:21:23PM -0700, Andrew Morton wrote:
> On Wed, 25 Aug 2010 17:55:00 +0900
> Joonyoung Shim <dofmind@gmail.com> wrote:
> 
> > 2010/8/6 Joonyoung Shim <jy0922.shim@samsung.com>:
> > > Hi.
> > >
> > > This patchset is to support the RTC provided by the Maxim 8998 chip. For
> > > this first, needs i2c interface changes and interrupts support of
> > > max8998 mfd driver.
> > >
> > > Changes since v1:
> > >  - Fix missing braces of 3/3 patch from v1 review.
> > >  - The rest is same with v1.
> > >
> > > Changes since v2:
> > >  - add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
> > >  - The rest is same with v2.
> > >
> > > Joonyoung Shim (3):
> > >      mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
> > >      mfd: MAX8998: Add interrupts support
> > >      rtc: Add MAX8998 rtc driver
> > >
> > 
> > Ping. Is there any feedback?
> 
> They look good to me.  Things are pretty delayed at present as I (and
> presumably others) recover from the -rc merge window..
> 
> I merged them.  Sam's acks on the MFD bits made life easier.
For some reasons I thought Liam was pushing this patchset through the last
merge window.
But now that the max8998 driver is upstreamed, I can carry those patches.

Cheers,
Samuel.


-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [PATCH v3 0/3] MAX8998 changes for RTC

[Liam Girdwood]

On Fri, 2010-09-10 at 18:39 +0200, Samuel Ortiz wrote:
> On Wed, Aug 25, 2010 at 12:21:23PM -0700, Andrew Morton wrote:
> > On Wed, 25 Aug 2010 17:55:00 +0900
> > Joonyoung Shim <dofmind@gmail.com> wrote:
> > 
> > > 2010/8/6 Joonyoung Shim <jy0922.shim@samsung.com>:
> > > > Hi.
> > > >
> > > > This patchset is to support the RTC provided by the Maxim 8998 chip. For
> > > > this first, needs i2c interface changes and interrupts support of
> > > > max8998 mfd driver.
> > > >
> > > > Changes since v1:
> > > >  - Fix missing braces of 3/3 patch from v1 review.
> > > >  - The rest is same with v1.
> > > >
> > > > Changes since v2:
> > > >  - add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
> > > >  - The rest is same with v2.
> > > >
> > > > Joonyoung Shim (3):
> > > >      mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
> > > >      mfd: MAX8998: Add interrupts support
> > > >      rtc: Add MAX8998 rtc driver
> > > >
> > > 
> > > Ping. Is there any feedback?
> > 
> > They look good to me.  Things are pretty delayed at present as I (and
> > presumably others) recover from the -rc merge window..
> > 
> > I merged them.  Sam's acks on the MFD bits made life easier.
> For some reasons I thought Liam was pushing this patchset through the last
> merge window.

Oh, that just might be my memory failing me here.... apologies if so.

> But now that the max8998 driver is upstreamed, I can carry those patches.
> 
 
Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk