Re: [PATCH] kconfig: fix make oldconfig

Justin P. Mattock
2010-08-06T19:51:59Z

On 08/06/2010 11:09 AM, Linus Torvalds wrote:
> On Fri, Aug 6, 2010 at 10:52 AM, Sam Ravnborg<sam@ravnborg.org> wrote:
>>
>> Hmm, I wonder why you call oldconfig explicitly?
>>
>> A plain "make -j16" executes "silentoldconfig" if there
>> is any changes in a Kconfig* file or in .config.
>> Just double checked and it works as I expected.
>>
>> So you are asked if there is any new options anyway even
>> if you skip your "oldconfig" step.
>
> Try this:
>
> git clean -dqfx
> make -j16> ../makes
>
> It doesn't work, because "make silentconfig" will say
>
> ***
> *** You have not yet configured your kernel!
> *** (missing kernel config file ".config")
> ***
> *** Please run some configurator (e.g. "make oldconfig" or
> *** "make menuconfig" or "make xconfig").
> ***
>
> which is why I always run "make oldconfig".
>
> Sure, I could do it only when I need to, but quite frankly, it's much
> easier to just always do the thing that works, rather than try
> something that doesn't work, do something else, and then re-try the
> thing that can fail.
>
> Linus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

the above command does break over here. using the make oldconfig command
seems to be working after I did the make menuconfig.

Now before doing all of this I did make a copy of the entire kernel for
a new system Im building(clfs) so I went into that tree and did a make
oldconfig and(luckily) hit the non responsive oldconfig thing that Linus
had originally posted.

here is a strace of when make oldconfig was not working(with git log at
the top)

http://fpaste.org/317B/

and strace of a git pull today and make oldconfig does not crap out and
starts asking me y/n options:

http://fpaste.org/QWWn/

hope this helps with debugging and such.

Justin P. Mattock