From: Tejun Heo <htejun@gmail.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
walt <w41ter@gmail.com>,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier
Date: Mon, 09 Aug 2010 11:49:00 +0200 [thread overview]
Message-ID: <4C5FCF0C.2000100@gmail.com> (raw)
In-Reply-To: <20100809094630.GA1603@arch.tripp.de>
Hello,
On 08/09/2010 11:46 AM, Markus Trippelsdorf wrote:
> This fixes the boot problem here. Thanks.
Great. May I add your Tested-by?
> (The drm delayed enqueue problem, which I mentioned earlier still
> persists.)
Yeah, I'm looking into it now but it looks like the error message is
simply spurious. queue_delayed_work() returns 1 if the work was
actually queued and 0 if it was already pending and thus the function
call was no-op. output_poll_execute() is incorrectly interpreting 1
return as error. I'll look through the history and try to find out
whether/how wq changes affected the behavior, but the fix is most
likely simply killing the message.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-08-09 9:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 20:17 [BISECTED] Today's Linus.git hangs during boot: can't find the floppy controller walt
2010-08-09 6:37 ` Markus Trippelsdorf
2010-08-09 8:30 ` Heiko Carstens
2010-08-09 8:34 ` Heiko Carstens
2010-08-09 9:04 ` Tejun Heo
2010-08-09 9:36 ` [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier Tejun Heo
2010-08-09 9:46 ` Markus Trippelsdorf
2010-08-09 9:49 ` Tejun Heo [this message]
2010-08-09 9:56 ` Markus Trippelsdorf
2010-08-09 10:00 ` [PATCH wq#for-linus] drm: fix a fallout from slow-work -> wq conversion Tejun Heo
2010-08-09 10:14 ` Markus Trippelsdorf
2010-08-09 10:20 ` [PATCH] drm: fix fallouts " Tejun Heo
2010-08-09 14:00 ` walt
2018-06-19 20:32 ` Dave Airlie
2010-08-09 13:56 ` [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier walt
2010-08-09 17:07 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5FCF0C.2000100@gmail.com \
--to=htejun@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=suresh.b.siddha@intel.com \
--cc=w41ter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).