From: walt <w41ter@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Robert Moore <robert.moore@intel.com>,
Len Brown <len.brown@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Steven Rostedt <rostedt@yahoo-wildcard.a05.yahoodns.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BISECTED] Removing BKL causes stack trace during early bootup
Date: Thu, 12 Aug 2010 12:40:04 -0700 [thread overview]
Message-ID: <4C644E14.60804@gmail.com> (raw)
In-Reply-To: <20100812182633.GB5369@nowhere>
On 08/12/2010 11:26 AM, Frederic Weisbecker wrote:
> (Adding ACPI guys and LKML in Cc)
>
> On Thu, Aug 12, 2010 at 11:09:03AM -0700, walt wrote:
>> Hi guys. This commit produces a non-fatal call trace very early during boot
>> on my dual-CPU amd64 machine (but not on my single-CPU x86):
>>
>> commit 5e3d20a68f63fc5a310687d81956c3b96e488b84
>> Author: Arnd Bergmann<arnd@xxxx.de>
>> Date: Sun Jul 4 00:02:26 2010 +0200
>>
>> init: Remove the BKL from startup code
>>
>
> Hi,
>
> Thanks for bisecting this.
> This is due to ACPI that does buggy checks and then sleeps too early.
>
> I'm attaching it here.
> diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
> index e5039a2..8da1e8c 100644
> --- a/include/acpi/platform/aclinux.h
> +++ b/include/acpi/platform/aclinux.h
> @@ -152,7 +152,7 @@ static inline void *acpi_os_acquire_object(acpi_cache_t * cache)
> #include<linux/hardirq.h>
> #define ACPI_PREEMPTION_POINT() \
> do { \
> - if (!in_atomic_preempt_off()&& !irqs_disabled()) \
> + if (!in_atomic()&& !irqs_disabled()) \
> cond_resched(); \
> } while (0)
>
Your patch eliminates my stack trace, thanks. Must be the same trace.
Nick, thanks for your excellent hints. The stack trace was obviously
scrolling off the top, as you suggested. Next time I'll notice it :)
next prev parent reply other threads:[~2010-08-12 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 18:09 [BISECTED] Removing BKL causes stack trace during early bootup walt
2010-08-12 18:26 ` Frederic Weisbecker
2010-08-12 19:40 ` walt [this message]
2010-08-12 18:36 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C644E14.60804@gmail.com \
--to=w41ter@gmail.com \
--cc=arnd@arndb.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=rostedt@yahoo-wildcard.a05.yahoodns.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox