From: Larry Finger <Larry.Finger@lwfinger.net>
To: john stultz <johnstul@us.ibm.com>
Cc: Jason Wessel <jason.wessel@windriver.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Problem with commit deda2e81961e96be4f2c09328baca4710a2fd1a0
Date: Thu, 12 Aug 2010 22:17:14 -0500 [thread overview]
Message-ID: <4C64B93A.5010403@lwfinger.net> (raw)
In-Reply-To: <1281646368.4002.66.camel@localhost.localdomain>
On 08/12/2010 03:52 PM, john stultz wrote:
>
> Ugh. I'm surprised it picks *this* loop to optimize instead of the
> similar one right above. I'm guessing its the local raw_nsecs value, but
> whatever. Also surprised Jason's testing didn't hit this issue, but its
> probably a gcc version thing.
>
> Regardless, I clearly need to give i386 more love in my testing.
> My profuse apologies.
>
> As suggested by Linus, here's the do_div explicit version. It builds ok
> on i386 & x86_64, but I have not yet tested it.
>
> Larry, Jason: Could you verify it works for you (and avoids the original
> issue)?
This one builds for me with both compilers. It appears to run OK. As to the
original issue - I don't think I ever saw the problem. I'll leave that question
for Jason.
Larry
next prev parent reply other threads:[~2010-08-13 3:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 20:18 Problem with commit deda2e81961e96be4f2c09328baca4710a2fd1a0 Larry Finger
2010-08-12 20:26 ` Linus Torvalds
2010-08-12 20:41 ` Larry Finger
2010-08-13 8:45 ` Mikael Pettersson
2010-08-12 20:52 ` john stultz
2010-08-13 3:17 ` Larry Finger [this message]
2010-08-13 7:30 ` john stultz
2010-08-13 11:53 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C64B93A.5010403@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=jason.wessel@windriver.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox