From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Igor Grinberg <grinberg@compulab.co.il>,
Mike Rapoport <mike@compulab.co.il>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] ARM: imx: fix build failure concerning otg/ulpi
Date: Fri, 13 Aug 2010 14:54:38 +0400 [thread overview]
Message-ID: <4C65246E.1000906@ru.mvista.com> (raw)
In-Reply-To: <1281694891-7527-1-git-send-email-u.kleine-koenig@pengutronix.de>
Hello.
Uwe Kleine-König wrote:
> The build failure was introduced by
>
> 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.)
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Mike Rapoport <mike@compulab.co.il>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signoff is missing.
> diff --git a/arch/arm/mach-imx/mach-cpuimx27.c b/arch/arm/mach-imx/mach-cpuimx27.c
> index 575ff1a..339150a 100644
> --- a/arch/arm/mach-imx/mach-cpuimx27.c
> +++ b/arch/arm/mach-imx/mach-cpuimx27.c
> @@ -279,13 +279,13 @@ static void __init eukrea_cpuimx27_init(void)
> #if defined(CONFIG_USB_ULPI)
> if (otg_mode_host) {
> otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT);
> + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT);
>
> mxc_register_device(&mxc_otg_host, &otg_pdata);
> }
>
> usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT);
> + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT);
>
> mxc_register_device(&mxc_usbh2, &usbh2_pdata);
> #endif
> diff --git a/arch/arm/mach-imx/mach-pca100.c b/arch/arm/mach-imx/mach-pca100.c
> index a389d11..23c9e1f 100644
> --- a/arch/arm/mach-imx/mach-pca100.c
> +++ b/arch/arm/mach-imx/mach-pca100.c
> @@ -419,13 +419,13 @@ static void __init pca100_init(void)
> #if defined(CONFIG_USB_ULPI)
> if (otg_mode_host) {
> otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT);
> + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT);
>
> mxc_register_device(&mxc_otg_host, &otg_pdata);
> }
>
> usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT);
> + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT);
>
> mxc_register_device(&mxc_usbh2, &usbh2_pdata);
> #endif
> diff --git a/arch/arm/mach-mx25/mach-cpuimx25.c b/arch/arm/mach-mx25/mach-cpuimx25.c
> index 56b2e26..0134fb8 100644
> --- a/arch/arm/mach-mx25/mach-cpuimx25.c
> +++ b/arch/arm/mach-mx25/mach-cpuimx25.c
> @@ -138,7 +138,7 @@ static void __init eukrea_cpuimx25_init(void)
> #if defined(CONFIG_USB_ULPI)
> if (otg_mode_host) {
> otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT);
> + USB_OTG_DRV_VBUS | ULPI_OTG_DRVVBUS_EXT);
Not ULPI_OTG_DRVVBUS, like in other cases?
>
> mxc_register_device(&mxc_otg, &otg_pdata);
> }
> diff --git a/arch/arm/mach-mx3/mach-cpuimx35.c b/arch/arm/mach-mx3/mach-cpuimx35.c
> index 63f970f..117f90e 100644
> --- a/arch/arm/mach-mx3/mach-cpuimx35.c
> +++ b/arch/arm/mach-mx3/mach-cpuimx35.c
> @@ -192,7 +192,7 @@ static void __init mxc_board_init(void)
> #if defined(CONFIG_USB_ULPI)
> if (otg_mode_host) {
> otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops,
> - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT);
> + USB_OTG_DRV_VBUS | ULPI_OTG_DRVVBUS_EXT);
Same question here...
WBR, Sergei
next prev parent reply other threads:[~2010-08-13 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1275464450-23003-2-git-send-email-grinberg@compulab.co.il>
2010-08-13 10:21 ` [PATCH] ARM: imx: fix build failure concerning otg/ulpi Uwe Kleine-König
2010-08-13 10:54 ` Sergei Shtylyov [this message]
2010-08-13 12:06 ` [PATCH v2] " Uwe Kleine-König
2010-08-15 6:05 ` Igor Grinberg
2010-08-16 4:53 ` Uwe Kleine-König
2010-08-16 6:09 ` Igor Grinberg
2010-08-22 7:24 ` Igor Grinberg
2010-08-22 17:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C65246E.1000906@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=gregkh@suse.de \
--cc=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox