From: Avi Kivity <avi@redhat.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: make mmu_shrink() fit shrinker's requirement
Date: Sun, 15 Aug 2010 14:14:14 +0300 [thread overview]
Message-ID: <4C67CC06.7070707@redhat.com> (raw)
In-Reply-To: <1281730204.30865.12.camel@nimitz>
On 08/13/2010 11:10 PM, Dave Hansen wrote:
> On Thu, 2010-08-05 at 12:28 +0300, Avi Kivity wrote:
>> On 08/04/2010 10:13 AM, Lai Jiangshan wrote:
>>> mmu_shrink() should attempt to free @nr_to_scan entries.
>> This conflicts with Dave's patchset.
>>
>> Dave, what's going on with those patches? They're starting to smell.
> These seem to fix the original problem reporter's issue. They were run
> with 64 guests on a 32GB machine. No stability problems popped up in
> this testing, or since I last sent the patches to you. The results from
> both the test with only the first four patches and with the entire set
> of nine looked pretty identical.
>
> That tells me that we should only push the first four for now:
>
> abstract kvm x86 mmu->n_free_mmu_pages
> rename x86 kvm->arch.n_alloc_mmu_pages
> replace x86 kvm n_free_mmu_pages with n_used_mmu_pages
> create aggregate kvm_total_used_mmu_pages value
Well, patches 3 and 4 have unaddressed review comments. Please fix them
up. If you don't have the time, let me know and I'll do it instead.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-15 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 7:13 [PATCH] kvm: make mmu_shrink() fit shrinker's requirement Lai Jiangshan
2010-08-05 9:28 ` Avi Kivity
2010-08-09 16:34 ` Dave Hansen
2010-08-13 20:10 ` Dave Hansen
2010-08-15 11:14 ` Avi Kivity [this message]
2010-08-16 23:55 ` Tim Pepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C67CC06.7070707@redhat.com \
--to=avi@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).