From: Michal Marek <mmarek@suse.cz>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Linux is full of bugs" <linux-kernel@vger.kernel.org>,
"Nir Tzachar" <nir.tzachar@gmail.com>
Subject: Re: BUG: nconfig doesn't preserve case in its menu display
Date: Tue, 17 Aug 2010 08:22:53 +0200 [thread overview]
Message-ID: <4C6A2ABD.1090002@suse.cz> (raw)
In-Reply-To: <4C69F7B9.2000103@cn.fujitsu.com>
On 17.8.2010 04:45, Li Zefan wrote:
> 于 2010年08月17日 05:04, Ævar Arnfjörð Bjarmason 写道:
>> When I do "make nconfig" and go to "General Setup" my "Local version -
>> append to kernel release" entry appears as:
>>
>> (-avar-akbar) Local version - append to kernel release
>>
>> When I use "make menuconfig" it's:
>>
>> (-Avar-Akbar) Local version - append to kernel release
>>
>> And my .config agrees:
>>
>> $ ack -n1 CONFIG_LOCALVERSION .config
>> CONFIG_LOCALVERSION="-Avar-Akbar"
>>
>> But when I edit the version string in both menuconfig and nconfig it
>> retains the correct casing.
>>
>> I briefly searched through the nconfig code, but couldn't find
>> anything pertinent to the localversion, so this is probably a more
>> general issue.
>
> The bug is in make_hot(). Here is the fix:
Nir removed the hotkeys feature in completely, can you try if the
problem persists in the for-next branch of
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git ?
The commit is a72f3e2.
Michal
prev parent reply other threads:[~2010-08-17 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 21:04 BUG: nconfig doesn't preserve case in its menu display Ævar Arnfjörð Bjarmason
2010-08-17 2:45 ` Li Zefan
2010-08-17 2:48 ` Li Zefan
2010-08-17 4:01 ` Ævar Arnfjörð Bjarmason
2010-08-17 5:12 ` Li Zefan
2010-08-17 5:21 ` Ævar Arnfjörð Bjarmason
2010-08-17 6:22 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6A2ABD.1090002@suse.cz \
--to=mmarek@suse.cz \
--cc=avarab@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=nir.tzachar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox