From: Michal Simek <monstr@monstr.eu>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: Fix missing includes
Date: Tue, 17 Aug 2010 09:52:21 +0200 [thread overview]
Message-ID: <4C6A3FB5.5060804@monstr.eu> (raw)
In-Reply-To: <AANLkTi=o+9mQeFWCvxkQNCZxvvfpkeXT9gEzvxZHhq_5@mail.gmail.com>
Grant Likely wrote:
> On Tue, Aug 17, 2010 at 1:45 AM, Michal Simek <monstr@monstr.eu> wrote:
>> Grant Likely wrote:
>>> This patch fixes missing includes from a number of .c files because
>>> the code (wrongfully) depended on prom.h including them. The include
>>> of linux/of_address.h was removed in microblaze prom.h in commit
>>> "of/address: Clean up function declarations" (sha1 id 22ae782f8), but
>>> not fixed in some users. This patch fixes them up.
>>>
>>> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>>> ---
>>>
>>> Hi Michal, here's my patch that fixes the microblaze include issues. I've
>>> got it in my merge-devicetree branch which I'll be asking Linus to pull on
>>> tommorrow after it has been through cross-arch build testing (unless I
>>> hear
>>> otherwise from you).
>> Tested-by: Michal Simek <monstr@monstr.eu>
>
> Thanks.
>
>> Miohal
>
> Who is Miohal, and why is he at your keyboard? :-D
I tried to use my new nickname but it seems you don't like it that's why
I will use only my given name. :-)
Cheers,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2010-08-17 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 6:00 [PATCH] of: Fix missing includes Grant Likely
2010-08-17 7:45 ` Michal Simek
2010-08-17 7:48 ` Grant Likely
2010-08-17 7:52 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6A3FB5.5060804@monstr.eu \
--to=monstr@monstr.eu \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox