From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756712Ab0HQJST (ORCPT ); Tue, 17 Aug 2010 05:18:19 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:42609 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443Ab0HQJSR (ORCPT ); Tue, 17 Aug 2010 05:18:17 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.5.1 Message-ID: <4C6A53E7.3090301@np.css.fujitsu.com> Date: Tue, 17 Aug 2010 18:18:31 +0900 From: Jin Dongming User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: Huang Ying CC: Randy Dunlap , Stephen Rothwell , Andi Kleen , Hidetoshi Seto , ACPI , LKLM Subject: Re: [PATCH 4/4] [Patch-next] ACPI, APEI, HEST Fix the unsuitable usage of platform_data. References: <4C69DEA5.1020902@np.css.fujitsu.com> <1282009188.2744.1498.camel@yhuang-dev> <4C69FB32.4000802@np.css.fujitsu.com> <1282018698.2744.1508.camel@yhuang-dev> In-Reply-To: <1282018698.2744.1508.camel@yhuang-dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2010/08/17 13:18), Huang Ying wrote: > On Tue, 2010-08-17 at 11:00 +0800, Jin Dongming wrote: >>> Why not use platform_device_add_data? >> Here what should be done is to transport the pointer of hest_hdr to platform_data, >> so I think that it could be done successfully by allocating 8byte of memory. >> If the platform_device_add_data() is used, the more memory will be allocated. >> >> So I think this method is better than using platform_device_add_data(). > > You can specify allocation size for platform_device_add_data(), so no > more memory will be allocated. > > Best Regards, > Huang Ying I am sorry for replying late. I will modify my patch and resend it again. Best Regards, Jin Dongming > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > >