From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757512Ab0HQKJq (ORCPT ); Tue, 17 Aug 2010 06:09:46 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:51464 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492Ab0HQKJp (ORCPT ); Tue, 17 Aug 2010 06:09:45 -0400 Message-ID: <4C6A5FE5.2090206@monstr.eu> Date: Tue, 17 Aug 2010 12:09:41 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: Alan Cox CC: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] serial: 8250pci: Recast inb return value References: <1282031947-16483-1-git-send-email-monstr@monstr.eu> <1282031947-16483-2-git-send-email-monstr@monstr.eu> <20100817110435.45e6ed8b@lxorguk.ukuu.org.uk> In-Reply-To: <20100817110435.45e6ed8b@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: > On Tue, 17 Aug 2010 09:59:07 +0200 > Michal Simek wrote: > >> inb returns u8 that's why is necessary to do recast. > > ret is an int, inb returns a u8, neither are pointers and the cast > required is implict and defined by the spec. ok. I am using gcc 4.1.2 which is likely the reason why I see that warnings. Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian