From: Clemens Ladisch <clemens@ladisch.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Yong Zhang <yong.zhang0@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: lockdep false positive? -- firewire-core transaction timer vs. scsi-core host lock
Date: Wed, 18 Aug 2010 15:05:02 +0200 [thread overview]
Message-ID: <4C6BDA7E.4080203@ladisch.de> (raw)
In-Reply-To: <tkrat.2aa42a952e4df4b1@s5r6.in-berlin.de>
Stefan Richter wrote:
> Clemens Ladisch wrote:
> > spin_lock_irqsave(&card->lock, flags);
> > list_for_each_entry(t, &card->transaction_list, link) {
> > if (t == transaction) {
> > + if (!del_timer(&t->split_timeout_timer))
> > + goto timed_out;
>
> + if (!del_timer(&t->split_timeout_timer)) {
> + spin_unlock_irqrestore(&card->lock, flags);
> + goto timed_out;
> + }
> Shall I commit with the added spin_unlocks?
I can obviously not be trusted to do this correctly; please go ahead.
Regards,
Clemens
prev parent reply other threads:[~2010-08-18 13:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 18:42 lockdep false positive? -- firewire-core transaction timer vs. scsi-core host lock Stefan Richter
2010-08-16 21:42 ` Peter Zijlstra
2010-08-16 22:09 ` Johannes Berg
2010-08-16 22:27 ` Johannes Berg
2010-08-17 16:22 ` Stefan Richter
2010-08-18 13:17 ` Stefan Richter
2010-08-17 14:35 ` Yong Zhang
2010-08-17 16:23 ` Stefan Richter
2010-08-18 7:01 ` Clemens Ladisch
2010-08-18 8:09 ` Stefan Richter
2010-08-18 8:53 ` Clemens Ladisch
2010-08-18 9:08 ` Yong Zhang
2010-08-18 8:59 ` Peter Zijlstra
2010-08-18 9:26 ` Clemens Ladisch
2010-08-18 9:43 ` Peter Zijlstra
2010-08-18 12:50 ` Stefan Richter
2010-08-18 13:05 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6BDA7E.4080203@ladisch.de \
--to=clemens@ladisch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=peterz@infradead.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox