* [PATCH] trivial: Use kzalloc in idedisk_prep_fn.
@ 2010-08-19 4:02 Tao Ma
2010-08-19 6:58 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Tao Ma @ 2010-08-19 4:02 UTC (permalink / raw)
To: linux-kernel; +Cc: Tao Ma, Jiri Kosina
Cc: Jiri Kosina <trivial@kernel.org>
Signed-off-by: Tao Ma <tao.ma@oracle.com>
---
drivers/ide/ide-disk.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 7433e07..471bb0d 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -435,12 +435,11 @@ static int idedisk_prep_fn(struct request_queue *q, struct request *rq)
if (!(rq->cmd_flags & REQ_FLUSH))
return BLKPREP_OK;
- cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC);
+ cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC);
/* FIXME: map struct ide_taskfile on rq->cmd[] */
BUG_ON(cmd == NULL);
- memset(cmd, 0, sizeof(*cmd));
if (ata_id_flush_ext_enabled(drive->id) &&
(drive->capacity64 >= (1UL << 28)))
cmd->tf.command = ATA_CMD_FLUSH_EXT;
--
1.7.1.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] trivial: Use kzalloc in idedisk_prep_fn.
2010-08-19 4:02 [PATCH] trivial: Use kzalloc in idedisk_prep_fn Tao Ma
@ 2010-08-19 6:58 ` Jeff Garzik
2010-08-19 8:55 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2010-08-19 6:58 UTC (permalink / raw)
To: Tao Ma; +Cc: linux-kernel, Jiri Kosina, Linux IDE mailing list
On 08/19/2010 12:02 AM, Tao Ma wrote:
> Cc: Jiri Kosina<trivial@kernel.org>
> Signed-off-by: Tao Ma<tao.ma@oracle.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] trivial: Use kzalloc in idedisk_prep_fn.
2010-08-19 6:58 ` Jeff Garzik
@ 2010-08-19 8:55 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2010-08-19 8:55 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Tao Ma, linux-kernel, Linux IDE mailing list
On Thu, 19 Aug 2010, Jeff Garzik wrote:
> > Cc: Jiri Kosina<trivial@kernel.org>
> > Signed-off-by: Tao Ma<tao.ma@oracle.com>
>
> Acked-by: Jeff Garzik <jgarzik@redhat.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-19 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-19 4:02 [PATCH] trivial: Use kzalloc in idedisk_prep_fn Tao Ma
2010-08-19 6:58 ` Jeff Garzik
2010-08-19 8:55 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox