public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mark Stanovich <mrktimber@gmail.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.35.3
Date: Fri, 20 Aug 2010 20:44:59 -0700	[thread overview]
Message-ID: <4C6F4BBB.5040207@zytor.com> (raw)
In-Reply-To: <AANLkTi=wyG13QOU3EQwaO3qBxY=aR=ftiP4s7YpemrPp@mail.gmail.com>

On 08/20/2010 08:40 PM, Mark Stanovich wrote:
> After updating to the 2.6.35.3 stable release, my machine was rebooting
> automatically during the first few seconds of boot.
> 
> I bisected to the first bad commit of
> 
> commit 568132624386f53e87575195d868db
> 9afb2e9316
> Author: H. Peter Anvin <hpa@zytor.com <mailto:hpa@zytor.com>>
> Date:   Tue Jul 27 17:01:49 2010 -0700
> 
>     x86: Add memory modify constraints to xchg() and cmpxchg()
>    
>     commit 113fc5a6e8c2288619ff7e8187a6f556b7e0d372 upstream.
>    
>     xchg() and cmpxchg() modify their memory operands, not merely read
>     them.  For some versions of gcc the "memory" clobber has apparently
>     dealt with the situation, but not for all.
>    
> I noticed that the latest version pulled from Linus's git tree did not
> have the problem.  After looking at the changes to
> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
> Linus's tree that seemed to make a difference, namely:
> 
> 69309a05907546fb686b251d4ab041c26afe1e1d
> 4532b305e8f0c238dd73048068ff8a6dd1380291
> 
> Applying these patches solved the rebooting problem on 2.6.35.3
> 
> I believe the same problem also happens for the latest stable version of
> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
> 
> I don't know if this is helpful, but I thought I would let you know in
> case someone else is having the same problem.
> 
> If you need any further information, just let me know.
> 

Yes, as a matter of fact, we have been trying to root-cause this
problem; please see:

https://bugzilla.kernel.org/show_bug.cgi?id=16612

If you could try the one-liner in there and see if it solves your
problem, it would be great.

	-hpa

P.S. What version of gcc do you use?

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


       reply	other threads:[~2010-08-21  3:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTi=wyG13QOU3EQwaO3qBxY=aR=ftiP4s7YpemrPp@mail.gmail.com>
2010-08-21  3:44 ` H. Peter Anvin [this message]
2010-08-21  4:06   ` Linux 2.6.35.3 Mark Stanovich
2010-08-21  4:41     ` H. Peter Anvin
2010-08-21  4:50       ` Greg KH
2010-08-23  1:31     ` H. Peter Anvin
2010-08-23  1:56       ` Mark Stanovich
2010-08-23  3:03         ` Greg KH
2010-08-23 13:47           ` Mark Stanovich
2010-08-23 21:35             ` Greg KH
2010-08-23 18:04   ` Michael Tokarev
2010-08-23 18:45     ` H. Peter Anvin
2010-08-21  3:44 Mark Stanovich
  -- strict thread matches above, loose matches on Subject: below --
2010-08-20 20:49 Greg KH
2010-08-20 20:49 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6F4BBB.5040207@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrktimber@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox