Linux 2.6.35.3

Linux 2.6.35.3

[Greg KH]

I'm announcing the release of the 2.6.35.3 kernel.

All users of the 2.6.35 kernel series must upgrade.

The updated 2.6.35.y git tree can be found at:
        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.35.y.git
and can be browsed at the normal kernel.org git web browser:
        http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.35.y.git;a=summary

thanks,

greg k-h

------------


 Makefile                     |    2 +-
 arch/x86/kernel/cpu/vmware.c |    1 +
 fs/proc/task_mmu.c           |    8 +++++++-
 mm/memory.c                  |   13 ++++++-------
 mm/mlock.c                   |    8 ++++++++
 5 files changed, 23 insertions(+), 9 deletions(-)

Greg Kroah-Hartman (2):
      vmware: fix build error in vmware.c
      Linux 2.6.35.3

Linus Torvalds (2):
      mm: fix page table unmap for stack guard page properly
      mm: fix up some user-visible effects of the stack guard page

Re: Linux 2.6.35.3

[Greg KH]

diff --git a/Makefile b/Makefile
index 3cf2397..554683d 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 35
-EXTRAVERSION = .2
+EXTRAVERSION = .3
 NAME = Sheep on Meth
 
 # *DOCUMENTATION*
diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c
index 227b044..ce9c6c2 100644
--- a/arch/x86/kernel/cpu/vmware.c
+++ b/arch/x86/kernel/cpu/vmware.c
@@ -23,6 +23,7 @@
 
 #include <linux/dmi.h>
 #include <linux/module.h>
+#include <linux/jiffies.h>
 #include <asm/div64.h>
 #include <asm/x86_init.h>
 #include <asm/hypervisor.h>
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index aea1d3f..439fc1f 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -210,6 +210,7 @@ static void show_map_vma(struct seq_file *m, struct vm_area_struct *vma)
 	int flags = vma->vm_flags;
 	unsigned long ino = 0;
 	unsigned long long pgoff = 0;
+	unsigned long start;
 	dev_t dev = 0;
 	int len;
 
@@ -220,8 +221,13 @@ static void show_map_vma(struct seq_file *m, struct vm_area_struct *vma)
 		pgoff = ((loff_t)vma->vm_pgoff) << PAGE_SHIFT;
 	}
 
+	/* We don't show the stack guard page in /proc/maps */
+	start = vma->vm_start;
+	if (vma->vm_flags & VM_GROWSDOWN)
+		start += PAGE_SIZE;
+
 	seq_printf(m, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu %n",
-			vma->vm_start,
+			start,
 			vma->vm_end,
 			flags & VM_READ ? 'r' : '-',
 			flags & VM_WRITE ? 'w' : '-',
diff --git a/mm/memory.c b/mm/memory.c
index aaaedbd..307bf77 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2792,24 +2792,23 @@ static int do_anonymous_page(struct mm_struct *mm, struct vm_area_struct *vma,
 	spinlock_t *ptl;
 	pte_t entry;
 
-	if (check_stack_guard_page(vma, address) < 0) {
-		pte_unmap(page_table);
+	pte_unmap(page_table);
+
+	/* Check if we need to add a guard page to the stack */
+	if (check_stack_guard_page(vma, address) < 0)
 		return VM_FAULT_SIGBUS;
-	}
 
+	/* Use the zero-page for reads */
 	if (!(flags & FAULT_FLAG_WRITE)) {
 		entry = pte_mkspecial(pfn_pte(my_zero_pfn(address),
 						vma->vm_page_prot));
-		ptl = pte_lockptr(mm, pmd);
-		spin_lock(ptl);
+		page_table = pte_offset_map_lock(mm, pmd, address, &ptl);
 		if (!pte_none(*page_table))
 			goto unlock;
 		goto setpte;
 	}
 
 	/* Allocate our own private page. */
-	pte_unmap(page_table);
-
 	if (unlikely(anon_vma_prepare(vma)))
 		goto oom;
 	page = alloc_zeroed_user_highpage_movable(vma, address);
diff --git a/mm/mlock.c b/mm/mlock.c
index 3f82720..49e5e4c 100644
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -167,6 +167,14 @@ static long __mlock_vma_pages_range(struct vm_area_struct *vma,
 	if (vma->vm_flags & VM_WRITE)
 		gup_flags |= FOLL_WRITE;
 
+	/* We don't try to access the guard page of a stack vma */
+	if (vma->vm_flags & VM_GROWSDOWN) {
+		if (start == vma->vm_start) {
+			start += PAGE_SIZE;
+			nr_pages--;
+		}
+	}
+
 	while (nr_pages > 0) {
 		int i;
 

Linux 2.6.35.3

[Mark Stanovich]

After updating to the 2.6.35.3 stable release, my machine was
rebooting automatically during the first few seconds of boot.

I bisected to the first bad commit of

commit 568132624386f53e87575195d868db
9afb2e9316
Author: H. Peter Anvin <hpa@zytor.com>
Date:   Tue Jul 27 17:01:49 2010 -0700

    x86: Add memory modify constraints to xchg() and cmpxchg()

    commit 113fc5a6e8c2288619ff7e8187a6f556b7e0d372 upstream.

    xchg() and cmpxchg() modify their memory operands, not merely read
    them.  For some versions of gcc the "memory" clobber has apparently
    dealt with the situation, but not for all.

I noticed that the latest version pulled from Linus's git tree did not
have the problem.  After looking at the changes to
arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
Linus's tree that seemed to make a difference, namely:

69309a05907546fb686b251d4ab041c26afe1e1d
4532b305e8f0c238dd73048068ff8a6dd1380291

Applying these patches solved the rebooting problem on 2.6.35.3

I believe the same problem also happens for the latest stable version
of 2.6.34, but did not verify the fix worked for the 2.6.34 stable
releases.

I don't know if this is helpful, but I thought I would let you know in
case someone else is having the same problem.

If you need any further information, just let me know.

    - Mark

Re: Linux 2.6.35.3

[H. Peter Anvin]

On 08/20/2010 08:40 PM, Mark Stanovich wrote:
> After updating to the 2.6.35.3 stable release, my machine was rebooting
> automatically during the first few seconds of boot.
> 
> I bisected to the first bad commit of
> 
> commit 568132624386f53e87575195d868db
> 9afb2e9316
> Author: H. Peter Anvin <hpa@zytor.com <mailto:hpa@zytor.com>>
> Date:   Tue Jul 27 17:01:49 2010 -0700
> 
>     x86: Add memory modify constraints to xchg() and cmpxchg()
>    
>     commit 113fc5a6e8c2288619ff7e8187a6f556b7e0d372 upstream.
>    
>     xchg() and cmpxchg() modify their memory operands, not merely read
>     them.  For some versions of gcc the "memory" clobber has apparently
>     dealt with the situation, but not for all.
>    
> I noticed that the latest version pulled from Linus's git tree did not
> have the problem.  After looking at the changes to
> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
> Linus's tree that seemed to make a difference, namely:
> 
> 69309a05907546fb686b251d4ab041c26afe1e1d
> 4532b305e8f0c238dd73048068ff8a6dd1380291
> 
> Applying these patches solved the rebooting problem on 2.6.35.3
> 
> I believe the same problem also happens for the latest stable version of
> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
> 
> I don't know if this is helpful, but I thought I would let you know in
> case someone else is having the same problem.
> 
> If you need any further information, just let me know.
> 

Yes, as a matter of fact, we have been trying to root-cause this
problem; please see:

https://bugzilla.kernel.org/show_bug.cgi?id=16612

If you could try the one-liner in there and see if it solves your
problem, it would be great.

	-hpa

P.S. What version of gcc do you use?

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: Linux 2.6.35.3

[Mark Stanovich]

On Fri, Aug 20, 2010 at 11:44 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 08/20/2010 08:40 PM, Mark Stanovich wrote:
>> After updating to the 2.6.35.3 stable release, my machine was rebooting
>> automatically during the first few seconds of boot.
>>
>> I bisected to the first bad commit of
>>
>> commit 568132624386f53e87575195d868db
>> 9afb2e9316
>> Author: H. Peter Anvin <hpa@zytor.com <mailto:hpa@zytor.com>>
>> Date:   Tue Jul 27 17:01:49 2010 -0700
>>
>>     x86: Add memory modify constraints to xchg() and cmpxchg()
>>
>>     commit 113fc5a6e8c2288619ff7e8187a6f556b7e0d372 upstream.
>>
>>     xchg() and cmpxchg() modify their memory operands, not merely read
>>     them.  For some versions of gcc the "memory" clobber has apparently
>>     dealt with the situation, but not for all.
>>
>> I noticed that the latest version pulled from Linus's git tree did not
>> have the problem.  After looking at the changes to
>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
>> Linus's tree that seemed to make a difference, namely:
>>
>> 69309a05907546fb686b251d4ab041c26afe1e1d
>> 4532b305e8f0c238dd73048068ff8a6dd1380291
>>
>> Applying these patches solved the rebooting problem on 2.6.35.3
>>
>> I believe the same problem also happens for the latest stable version of
>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
>>
>> I don't know if this is helpful, but I thought I would let you know in
>> case someone else is having the same problem.
>>
>> If you need any further information, just let me know.
>>
>
> Yes, as a matter of fact, we have been trying to root-cause this
> problem; please see:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=16612
>
> If you could try the one-liner in there and see if it solves your
> problem, it would be great.

The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!

>
>        -hpa
>
> P.S. What version of gcc do you use?

gcc (Gentoo 4.4.3-r2 p1.2) 4.4.3

Thanks,
Mark

Re: Linux 2.6.35.3

[H. Peter Anvin]

[-- Attachment #1: Type: text/plain, Size: 2559 bytes --]

OK, I think we can consider this root-caused (it's unclear if it's our
bug or gcc's, but adding "volatile" to the pointer solves the problem.)

Greg, do you want to take the listed upstream patches (thus bringing the
code closer to mainline) or do you want to take the one-liner patch from
the bugzilla?  [Attached for reference?]

	-hpa



On 08/20/2010 09:06 PM, Mark Stanovich wrote:
> On Fri, Aug 20, 2010 at 11:44 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 08/20/2010 08:40 PM, Mark Stanovich wrote:
>>> After updating to the 2.6.35.3 stable release, my machine was rebooting
>>> automatically during the first few seconds of boot.
>>>
>>> I bisected to the first bad commit of
>>>
>>> commit 568132624386f53e87575195d868db
>>> 9afb2e9316
>>> Author: H. Peter Anvin <hpa@zytor.com <mailto:hpa@zytor.com>>
>>> Date:   Tue Jul 27 17:01:49 2010 -0700
>>>
>>>     x86: Add memory modify constraints to xchg() and cmpxchg()
>>>
>>>     commit 113fc5a6e8c2288619ff7e8187a6f556b7e0d372 upstream.
>>>
>>>     xchg() and cmpxchg() modify their memory operands, not merely read
>>>     them.  For some versions of gcc the "memory" clobber has apparently
>>>     dealt with the situation, but not for all.
>>>
>>> I noticed that the latest version pulled from Linus's git tree did not
>>> have the problem.  After looking at the changes to
>>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
>>> Linus's tree that seemed to make a difference, namely:
>>>
>>> 69309a05907546fb686b251d4ab041c26afe1e1d
>>> 4532b305e8f0c238dd73048068ff8a6dd1380291
>>>
>>> Applying these patches solved the rebooting problem on 2.6.35.3
>>>
>>> I believe the same problem also happens for the latest stable version of
>>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
>>>
>>> I don't know if this is helpful, but I thought I would let you know in
>>> case someone else is having the same problem.
>>>
>>> If you need any further information, just let me know.
>>>
>>
>> Yes, as a matter of fact, we have been trying to root-cause this
>> problem; please see:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=16612
>>
>> If you could try the one-liner in there and see if it solves your
>> problem, it would be great.
> 
> The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!
> 
>>
>>        -hpa
>>
>> P.S. What version of gcc do you use?
> 
> gcc (Gentoo 4.4.3-r2 p1.2) 4.4.3
> 
> Thanks,
> Mark
> 


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


[-- Attachment #2: volatilize.patch --]
[-- Type: text/x-patch, Size: 548 bytes --]

diff --git a/arch/x86/include/asm/cmpxchg_32.h b/arch/x86/include/asm/cmpxchg_32.h
index c1cf59d..e022d0c 100644
--- a/arch/x86/include/asm/cmpxchg_32.h
+++ b/arch/x86/include/asm/cmpxchg_32.h
@@ -66,7 +66,7 @@ struct __xchg_dummy {
  * of the instruction set reference 24319102.pdf. We need
  * the reader side to see the coherent 64bit value.
  */
-static inline void __set_64bit(unsigned long long *ptr,
+static inline void __set_64bit(volatile unsigned long long *ptr,
 			       unsigned int low, unsigned int high)
 {
 	asm volatile("\n1:\t"

Re: Linux 2.6.35.3

[Greg KH]

On Fri, Aug 20, 2010 at 09:41:02PM -0700, H. Peter Anvin wrote:
> OK, I think we can consider this root-caused (it's unclear if it's our
> bug or gcc's, but adding "volatile" to the pointer solves the problem.)
> 
> Greg, do you want to take the listed upstream patches (thus bringing the
> code closer to mainline) or do you want to take the one-liner patch from
> the bugzilla?  [Attached for reference?]

Let me look at the 2 upstream patches tomorrow, and I'd prefer to take
them instead of something else, just to keep everything in sync.

thanks,

greg k-h

Re: Linux 2.6.35.3

[H. Peter Anvin]

On 08/20/2010 09:06 PM, Mark Stanovich wrote:
>>>
>>> I noticed that the latest version pulled from Linus's git tree did not
>>> have the problem.  After looking at the changes to
>>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
>>> Linus's tree that seemed to make a difference, namely:
>>>
>>> 69309a05907546fb686b251d4ab041c26afe1e1d
>>> 4532b305e8f0c238dd73048068ff8a6dd1380291
>>>
>>> Applying these patches solved the rebooting problem on 2.6.35.3
>>>
>>> I believe the same problem also happens for the latest stable version of
>>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
>>>
>>> I don't know if this is helpful, but I thought I would let you know in
>>> case someone else is having the same problem.
>>>
>>> If you need any further information, just let me know.
>>>
>>
>> Yes, as a matter of fact, we have been trying to root-cause this
>> problem; please see:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=16612
>>
>> If you could try the one-liner in there and see if it solves your
>> problem, it would be great.
> 
> The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!
> 
> 

By the way, I think only 69309a05907546fb686b251d4ab041c26afe1e1d should
solve the problem.  Mark, could you try only this patch?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: Linux 2.6.35.3

[Mark Stanovich]

On Sun, Aug 22, 2010 at 9:31 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 08/20/2010 09:06 PM, Mark Stanovich wrote:
>>>>
>>>> I noticed that the latest version pulled from Linus's git tree did not
>>>> have the problem.  After looking at the changes to
>>>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
>>>> Linus's tree that seemed to make a difference, namely:
>>>>
>>>> 69309a05907546fb686b251d4ab041c26afe1e1d
>>>> 4532b305e8f0c238dd73048068ff8a6dd1380291
>>>>
>>>> Applying these patches solved the rebooting problem on 2.6.35.3
>>>>
>>>> I believe the same problem also happens for the latest stable version of
>>>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
>>>>
>>>> I don't know if this is helpful, but I thought I would let you know in
>>>> case someone else is having the same problem.
>>>>
>>>> If you need any further information, just let me know.
>>>>
>>>
>>> Yes, as a matter of fact, we have been trying to root-cause this
>>> problem; please see:
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=16612
>>>
>>> If you could try the one-liner in there and see if it solves your
>>> problem, it would be great.
>>
>> The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!
>>
>>
>
> By the way, I think only 69309a05907546fb686b251d4ab041c26afe1e1d should
> solve the problem.  Mark, could you try only this patch?
>

Tested 69309a05907546fb686b251d4ab041c26afe1e1d on top of 2.6.35.3 and
this does solve the rebooting problem.

    - Mark

Re: Linux 2.6.35.3

[Greg KH]

On Sun, Aug 22, 2010 at 09:56:19PM -0400, Mark Stanovich wrote:
> On Sun, Aug 22, 2010 at 9:31 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> > On 08/20/2010 09:06 PM, Mark Stanovich wrote:
> >>>>
> >>>> I noticed that the latest version pulled from Linus's git tree did not
> >>>> have the problem. ?After looking at the changes to
> >>>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
> >>>> Linus's tree that seemed to make a difference, namely:
> >>>>
> >>>> 69309a05907546fb686b251d4ab041c26afe1e1d
> >>>> 4532b305e8f0c238dd73048068ff8a6dd1380291
> >>>>
> >>>> Applying these patches solved the rebooting problem on 2.6.35.3
> >>>>
> >>>> I believe the same problem also happens for the latest stable version of
> >>>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
> >>>>
> >>>> I don't know if this is helpful, but I thought I would let you know in
> >>>> case someone else is having the same problem.
> >>>>
> >>>> If you need any further information, just let me know.
> >>>>
> >>>
> >>> Yes, as a matter of fact, we have been trying to root-cause this
> >>> problem; please see:
> >>>
> >>> https://bugzilla.kernel.org/show_bug.cgi?id=16612
> >>>
> >>> If you could try the one-liner in there and see if it solves your
> >>> problem, it would be great.
> >>
> >> The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!
> >>
> >>
> >
> > By the way, I think only 69309a05907546fb686b251d4ab041c26afe1e1d should
> > solve the problem. ?Mark, could you try only this patch?
> >
> 
> Tested 69309a05907546fb686b251d4ab041c26afe1e1d on top of 2.6.35.3 and
> this does solve the rebooting problem.

Wonderful, thanks for testing, I'll just queue this one up then.

greg k-h

Re: Linux 2.6.35.3

[Mark Stanovich]

On Sun, Aug 22, 2010 at 11:03 PM, Greg KH <gregkh@suse.de> wrote:
> On Sun, Aug 22, 2010 at 09:56:19PM -0400, Mark Stanovich wrote:
>> On Sun, Aug 22, 2010 at 9:31 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> > On 08/20/2010 09:06 PM, Mark Stanovich wrote:
>> >>>>
>> >>>> I noticed that the latest version pulled from Linus's git tree did not
>> >>>> have the problem. ?After looking at the changes to
>> >>>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
>> >>>> Linus's tree that seemed to make a difference, namely:
>> >>>>
>> >>>> 69309a05907546fb686b251d4ab041c26afe1e1d
>> >>>> 4532b305e8f0c238dd73048068ff8a6dd1380291
>> >>>>
>> >>>> Applying these patches solved the rebooting problem on 2.6.35.3
>> >>>>
>> >>>> I believe the same problem also happens for the latest stable version of
>> >>>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
>> >>>>
>> >>>> I don't know if this is helpful, but I thought I would let you know in
>> >>>> case someone else is having the same problem.
>> >>>>
>> >>>> If you need any further information, just let me know.
>> >>>>
>> >>>
>> >>> Yes, as a matter of fact, we have been trying to root-cause this
>> >>> problem; please see:
>> >>>
>> >>> https://bugzilla.kernel.org/show_bug.cgi?id=16612
>> >>>
>> >>> If you could try the one-liner in there and see if it solves your
>> >>> problem, it would be great.
>> >>
>> >> The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!
>> >>
>> >>
>> >
>> > By the way, I think only 69309a05907546fb686b251d4ab041c26afe1e1d should
>> > solve the problem. ?Mark, could you try only this patch?
>> >
>>
>> Tested 69309a05907546fb686b251d4ab041c26afe1e1d on top of 2.6.35.3 and
>> this does solve the rebooting problem.
>

69309a05907546fb686b251d4ab041c26afe1e1d is also needed on top of
2.6.34.5 in order for my machine to boot properly.

    - Mark

Re: Linux 2.6.35.3

[Michael Tokarev]

21.08.2010 07:44, H. Peter Anvin wrote:
> On 08/20/2010 08:40 PM, Mark Stanovich wrote:
>> After updating to the 2.6.35.3 stable release, my machine was rebooting
>> automatically during the first few seconds of boot.
>>
>> I bisected to the first bad commit of
>>
>> commit 568132624386f53e87575195d868db
>> 9afb2e9316
>> Author: H. Peter Anvin <hpa@zytor.com <mailto:hpa@zytor.com>>
>> Date:   Tue Jul 27 17:01:49 2010 -0700
>>
>>     x86: Add memory modify constraints to xchg() and cmpxchg()

This commit also present in 2.6.32.stable (since 2.6.32.19).
Should it be fixed there as well?

Thanks!

/mjt

Re: Linux 2.6.35.3

[H. Peter Anvin]

On 08/23/2010 11:04 AM, Michael Tokarev wrote:
> 21.08.2010 07:44, H. Peter Anvin wrote:
>> On 08/20/2010 08:40 PM, Mark Stanovich wrote:
>>> After updating to the 2.6.35.3 stable release, my machine was rebooting
>>> automatically during the first few seconds of boot.
>>>
>>> I bisected to the first bad commit of
>>>
>>> commit 568132624386f53e87575195d868db
>>> 9afb2e9316
>>> Author: H. Peter Anvin <hpa@zytor.com <mailto:hpa@zytor.com>>
>>> Date:   Tue Jul 27 17:01:49 2010 -0700
>>>
>>>     x86: Add memory modify constraints to xchg() and cmpxchg()
> 
> This commit also present in 2.6.32.stable (since 2.6.32.19).
> Should it be fixed there as well?
> 

Yes, in particular 69309a05907546fb686b251d4ab041c26afe1e1d should be
applied to all instances of this commit.

As far as we can tell it's a gcc bug, but it hasn't been thoroughly
root-caused to that yet.

	-hpa

Re: Linux 2.6.35.3

[Greg KH]

On Mon, Aug 23, 2010 at 09:47:23AM -0400, Mark Stanovich wrote:
> On Sun, Aug 22, 2010 at 11:03 PM, Greg KH <gregkh@suse.de> wrote:
> > On Sun, Aug 22, 2010 at 09:56:19PM -0400, Mark Stanovich wrote:
> >> On Sun, Aug 22, 2010 at 9:31 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> >> > On 08/20/2010 09:06 PM, Mark Stanovich wrote:
> >> >>>>
> >> >>>> I noticed that the latest version pulled from Linus's git tree did not
> >> >>>> have the problem. ?After looking at the changes to
> >> >>>> arch/x86/include/asm/cmpxchg_32.h, I cherry-picked two patches from
> >> >>>> Linus's tree that seemed to make a difference, namely:
> >> >>>>
> >> >>>> 69309a05907546fb686b251d4ab041c26afe1e1d
> >> >>>> 4532b305e8f0c238dd73048068ff8a6dd1380291
> >> >>>>
> >> >>>> Applying these patches solved the rebooting problem on 2.6.35.3
> >> >>>>
> >> >>>> I believe the same problem also happens for the latest stable version of
> >> >>>> 2.6.34, but did not verify the fix worked for the 2.6.34 stable releases.
> >> >>>>
> >> >>>> I don't know if this is helpful, but I thought I would let you know in
> >> >>>> case someone else is having the same problem.
> >> >>>>
> >> >>>> If you need any further information, just let me know.
> >> >>>>
> >> >>>
> >> >>> Yes, as a matter of fact, we have been trying to root-cause this
> >> >>> problem; please see:
> >> >>>
> >> >>> https://bugzilla.kernel.org/show_bug.cgi?id=16612
> >> >>>
> >> >>> If you could try the one-liner in there and see if it solves your
> >> >>> problem, it would be great.
> >> >>
> >> >> The patch for __set_64bit on top of 2.6.35.3 solves the rebooting problem!
> >> >>
> >> >>
> >> >
> >> > By the way, I think only 69309a05907546fb686b251d4ab041c26afe1e1d should
> >> > solve the problem. ?Mark, could you try only this patch?
> >> >
> >>
> >> Tested 69309a05907546fb686b251d4ab041c26afe1e1d on top of 2.6.35.3 and
> >> this does solve the rebooting problem.
> >
> 
> 69309a05907546fb686b251d4ab041c26afe1e1d is also needed on top of
> 2.6.34.5 in order for my machine to boot properly.

Ok, now queued up for both .34 and .35 stable trees.

thanks,

greg k-h