* [PATCH] ARM: imx: fix build failure concerning otg/ulpi [not found] <1275464450-23003-2-git-send-email-grinberg@compulab.co.il> @ 2010-08-13 10:21 ` Uwe Kleine-König 2010-08-13 10:54 ` Sergei Shtylyov 0 siblings, 1 reply; 8+ messages in thread From: Uwe Kleine-König @ 2010-08-13 10:21 UTC (permalink / raw) To: linux-arm-kernel, linux-kernel, linux-usb Cc: Igor Grinberg, Mike Rapoport, Greg Kroah-Hartman The build failure was introduced by 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) Cc: Igor Grinberg <grinberg@compulab.co.il> Cc: Mike Rapoport <mike@compulab.co.il> Cc: Greg Kroah-Hartman <gregkh@suse.de> --- arch/arm/mach-imx/mach-cpuimx27.c | 4 ++-- arch/arm/mach-imx/mach-pca100.c | 4 ++-- arch/arm/mach-mx25/mach-cpuimx25.c | 2 +- arch/arm/mach-mx3/mach-cpuimx35.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-imx/mach-cpuimx27.c b/arch/arm/mach-imx/mach-cpuimx27.c index 575ff1a..339150a 100644 --- a/arch/arm/mach-imx/mach-cpuimx27.c +++ b/arch/arm/mach-imx/mach-cpuimx27.c @@ -279,13 +279,13 @@ static void __init eukrea_cpuimx27_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg_host, &otg_pdata); } usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_usbh2, &usbh2_pdata); #endif diff --git a/arch/arm/mach-imx/mach-pca100.c b/arch/arm/mach-imx/mach-pca100.c index a389d11..23c9e1f 100644 --- a/arch/arm/mach-imx/mach-pca100.c +++ b/arch/arm/mach-imx/mach-pca100.c @@ -419,13 +419,13 @@ static void __init pca100_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg_host, &otg_pdata); } usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_usbh2, &usbh2_pdata); #endif diff --git a/arch/arm/mach-mx25/mach-cpuimx25.c b/arch/arm/mach-mx25/mach-cpuimx25.c index 56b2e26..0134fb8 100644 --- a/arch/arm/mach-mx25/mach-cpuimx25.c +++ b/arch/arm/mach-mx25/mach-cpuimx25.c @@ -138,7 +138,7 @@ static void __init eukrea_cpuimx25_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + USB_OTG_DRV_VBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg, &otg_pdata); } diff --git a/arch/arm/mach-mx3/mach-cpuimx35.c b/arch/arm/mach-mx3/mach-cpuimx35.c index 63f970f..117f90e 100644 --- a/arch/arm/mach-mx3/mach-cpuimx35.c +++ b/arch/arm/mach-mx3/mach-cpuimx35.c @@ -192,7 +192,7 @@ static void __init mxc_board_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + USB_OTG_DRV_VBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg_host, &otg_pdata); } -- 1.7.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: imx: fix build failure concerning otg/ulpi 2010-08-13 10:21 ` [PATCH] ARM: imx: fix build failure concerning otg/ulpi Uwe Kleine-König @ 2010-08-13 10:54 ` Sergei Shtylyov 2010-08-13 12:06 ` [PATCH v2] " Uwe Kleine-König 0 siblings, 1 reply; 8+ messages in thread From: Sergei Shtylyov @ 2010-08-13 10:54 UTC (permalink / raw) To: Uwe Kleine-König Cc: linux-arm-kernel, linux-kernel, linux-usb, Igor Grinberg, Mike Rapoport, Greg Kroah-Hartman Hello. Uwe Kleine-König wrote: > The build failure was introduced by > > 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) > Cc: Igor Grinberg <grinberg@compulab.co.il> > Cc: Mike Rapoport <mike@compulab.co.il> > Cc: Greg Kroah-Hartman <gregkh@suse.de> Signoff is missing. > diff --git a/arch/arm/mach-imx/mach-cpuimx27.c b/arch/arm/mach-imx/mach-cpuimx27.c > index 575ff1a..339150a 100644 > --- a/arch/arm/mach-imx/mach-cpuimx27.c > +++ b/arch/arm/mach-imx/mach-cpuimx27.c > @@ -279,13 +279,13 @@ static void __init eukrea_cpuimx27_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_otg_host, &otg_pdata); > } > > usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_usbh2, &usbh2_pdata); > #endif > diff --git a/arch/arm/mach-imx/mach-pca100.c b/arch/arm/mach-imx/mach-pca100.c > index a389d11..23c9e1f 100644 > --- a/arch/arm/mach-imx/mach-pca100.c > +++ b/arch/arm/mach-imx/mach-pca100.c > @@ -419,13 +419,13 @@ static void __init pca100_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_otg_host, &otg_pdata); > } > > usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_usbh2, &usbh2_pdata); > #endif > diff --git a/arch/arm/mach-mx25/mach-cpuimx25.c b/arch/arm/mach-mx25/mach-cpuimx25.c > index 56b2e26..0134fb8 100644 > --- a/arch/arm/mach-mx25/mach-cpuimx25.c > +++ b/arch/arm/mach-mx25/mach-cpuimx25.c > @@ -138,7 +138,7 @@ static void __init eukrea_cpuimx25_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + USB_OTG_DRV_VBUS | ULPI_OTG_DRVVBUS_EXT); Not ULPI_OTG_DRVVBUS, like in other cases? > > mxc_register_device(&mxc_otg, &otg_pdata); > } > diff --git a/arch/arm/mach-mx3/mach-cpuimx35.c b/arch/arm/mach-mx3/mach-cpuimx35.c > index 63f970f..117f90e 100644 > --- a/arch/arm/mach-mx3/mach-cpuimx35.c > +++ b/arch/arm/mach-mx3/mach-cpuimx35.c > @@ -192,7 +192,7 @@ static void __init mxc_board_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + USB_OTG_DRV_VBUS | ULPI_OTG_DRVVBUS_EXT); Same question here... WBR, Sergei ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi 2010-08-13 10:54 ` Sergei Shtylyov @ 2010-08-13 12:06 ` Uwe Kleine-König 2010-08-15 6:05 ` Igor Grinberg 0 siblings, 1 reply; 8+ messages in thread From: Uwe Kleine-König @ 2010-08-13 12:06 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel, linux-usb Cc: Sergei Shtylyov, Igor Grinberg, Mike Rapoport, Greg Kroah-Hartman The build failure was introduced by 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) Cc: Igor Grinberg <grinberg@compulab.co.il> Cc: Mike Rapoport <mike@compulab.co.il> Cc: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- arch/arm/mach-imx/mach-cpuimx27.c | 4 ++-- arch/arm/mach-imx/mach-pca100.c | 4 ++-- arch/arm/mach-mx25/mach-cpuimx25.c | 2 +- arch/arm/mach-mx3/mach-cpuimx35.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-imx/mach-cpuimx27.c b/arch/arm/mach-imx/mach-cpuimx27.c index 575ff1a..339150a 100644 --- a/arch/arm/mach-imx/mach-cpuimx27.c +++ b/arch/arm/mach-imx/mach-cpuimx27.c @@ -279,13 +279,13 @@ static void __init eukrea_cpuimx27_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg_host, &otg_pdata); } usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_usbh2, &usbh2_pdata); #endif diff --git a/arch/arm/mach-imx/mach-pca100.c b/arch/arm/mach-imx/mach-pca100.c index a389d11..23c9e1f 100644 --- a/arch/arm/mach-imx/mach-pca100.c +++ b/arch/arm/mach-imx/mach-pca100.c @@ -419,13 +419,13 @@ static void __init pca100_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg_host, &otg_pdata); } usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_usbh2, &usbh2_pdata); #endif diff --git a/arch/arm/mach-mx25/mach-cpuimx25.c b/arch/arm/mach-mx25/mach-cpuimx25.c index 56b2e26..a5f0174 100644 --- a/arch/arm/mach-mx25/mach-cpuimx25.c +++ b/arch/arm/mach-mx25/mach-cpuimx25.c @@ -138,7 +138,7 @@ static void __init eukrea_cpuimx25_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg, &otg_pdata); } diff --git a/arch/arm/mach-mx3/mach-cpuimx35.c b/arch/arm/mach-mx3/mach-cpuimx35.c index 63f970f..9770a6a 100644 --- a/arch/arm/mach-mx3/mach-cpuimx35.c +++ b/arch/arm/mach-mx3/mach-cpuimx35.c @@ -192,7 +192,7 @@ static void __init mxc_board_init(void) #if defined(CONFIG_USB_ULPI) if (otg_mode_host) { otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); mxc_register_device(&mxc_otg_host, &otg_pdata); } -- 1.7.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi 2010-08-13 12:06 ` [PATCH v2] " Uwe Kleine-König @ 2010-08-15 6:05 ` Igor Grinberg 2010-08-16 4:53 ` Uwe Kleine-König 0 siblings, 1 reply; 8+ messages in thread From: Igor Grinberg @ 2010-08-15 6:05 UTC (permalink / raw) To: Uwe Kleine-König Cc: linux-kernel, linux-arm-kernel, linux-usb, Sergei Shtylyov, Mike Rapoport, Greg Kroah-Hartman On 08/13/10 15:06, Uwe Kleine-König wrote: > The build failure was introduced by > > 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) > > Cc: Igor Grinberg <grinberg@compulab.co.il> > Cc: Mike Rapoport <mike@compulab.co.il> > Cc: Greg Kroah-Hartman <gregkh@suse.de> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > I've based my patches on v2.6.35-rc6, so I could not patch those imx variants, sorry... But I did deal with mach-pca100.c, so I think moving it from mach-mx2 to mach-imx is what made it miss my patch. Anyway, this looks like the right addition. Thanks > --- > arch/arm/mach-imx/mach-cpuimx27.c | 4 ++-- > arch/arm/mach-imx/mach-pca100.c | 4 ++-- > arch/arm/mach-mx25/mach-cpuimx25.c | 2 +- > arch/arm/mach-mx3/mach-cpuimx35.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-imx/mach-cpuimx27.c b/arch/arm/mach-imx/mach-cpuimx27.c > index 575ff1a..339150a 100644 > --- a/arch/arm/mach-imx/mach-cpuimx27.c > +++ b/arch/arm/mach-imx/mach-cpuimx27.c > @@ -279,13 +279,13 @@ static void __init eukrea_cpuimx27_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_otg_host, &otg_pdata); > } > > usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_usbh2, &usbh2_pdata); > #endif > diff --git a/arch/arm/mach-imx/mach-pca100.c b/arch/arm/mach-imx/mach-pca100.c > index a389d11..23c9e1f 100644 > --- a/arch/arm/mach-imx/mach-pca100.c > +++ b/arch/arm/mach-imx/mach-pca100.c > @@ -419,13 +419,13 @@ static void __init pca100_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_otg_host, &otg_pdata); > } > > usbh2_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_usbh2, &usbh2_pdata); > #endif > diff --git a/arch/arm/mach-mx25/mach-cpuimx25.c b/arch/arm/mach-mx25/mach-cpuimx25.c > index 56b2e26..a5f0174 100644 > --- a/arch/arm/mach-mx25/mach-cpuimx25.c > +++ b/arch/arm/mach-mx25/mach-cpuimx25.c > @@ -138,7 +138,7 @@ static void __init eukrea_cpuimx25_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_otg, &otg_pdata); > } > diff --git a/arch/arm/mach-mx3/mach-cpuimx35.c b/arch/arm/mach-mx3/mach-cpuimx35.c > index 63f970f..9770a6a 100644 > --- a/arch/arm/mach-mx3/mach-cpuimx35.c > +++ b/arch/arm/mach-mx3/mach-cpuimx35.c > @@ -192,7 +192,7 @@ static void __init mxc_board_init(void) > #if defined(CONFIG_USB_ULPI) > if (otg_mode_host) { > otg_pdata.otg = otg_ulpi_create(&mxc_ulpi_access_ops, > - USB_OTG_DRV_VBUS | USB_OTG_DRV_VBUS_EXT); > + ULPI_OTG_DRVVBUS | ULPI_OTG_DRVVBUS_EXT); > > mxc_register_device(&mxc_otg_host, &otg_pdata); > } > -- Regards, Igor. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi 2010-08-15 6:05 ` Igor Grinberg @ 2010-08-16 4:53 ` Uwe Kleine-König 2010-08-16 6:09 ` Igor Grinberg 0 siblings, 1 reply; 8+ messages in thread From: Uwe Kleine-König @ 2010-08-16 4:53 UTC (permalink / raw) To: Igor Grinberg Cc: linux-kernel, linux-arm-kernel, linux-usb, Sergei Shtylyov, Mike Rapoport, Greg Kroah-Hartman Hello Igor, On Sun, Aug 15, 2010 at 09:05:59AM +0300, Igor Grinberg wrote: > On 08/13/10 15:06, Uwe Kleine-König wrote: > > The build failure was introduced by > > > > 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) > > > > Cc: Igor Grinberg <grinberg@compulab.co.il> > > Cc: Mike Rapoport <mike@compulab.co.il> > > Cc: Greg Kroah-Hartman <gregkh@suse.de> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > I've based my patches on v2.6.35-rc6, so I could not patch > those imx variants, sorry... > But I did deal with mach-pca100.c, so I think moving it from > mach-mx2 to mach-imx is what made it miss my patch. > > Anyway, this looks like the right addition. I assume this is an Ack? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi 2010-08-16 4:53 ` Uwe Kleine-König @ 2010-08-16 6:09 ` Igor Grinberg 2010-08-22 7:24 ` Igor Grinberg 0 siblings, 1 reply; 8+ messages in thread From: Igor Grinberg @ 2010-08-16 6:09 UTC (permalink / raw) To: Uwe Kleine-König Cc: linux-kernel, linux-arm-kernel, linux-usb, Sergei Shtylyov, Mike Rapoport, Greg Kroah-Hartman On 08/16/10 07:53, Uwe Kleine-König wrote: > Hello Igor, > > On Sun, Aug 15, 2010 at 09:05:59AM +0300, Igor Grinberg wrote: > >> On 08/13/10 15:06, Uwe Kleine-König wrote: >> >>> The build failure was introduced by >>> >>> 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) >>> >>> Cc: Igor Grinberg <grinberg@compulab.co.il> >>> Cc: Mike Rapoport <mike@compulab.co.il> >>> Cc: Greg Kroah-Hartman <gregkh@suse.de> >>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >>> >>> >> I've based my patches on v2.6.35-rc6, so I could not patch >> those imx variants, sorry... >> But I did deal with mach-pca100.c, so I think moving it from >> mach-mx2 to mach-imx is what made it miss my patch. >> >> Anyway, this looks like the right addition. >> > I assume this is an Ack? > Acked-by: Igor Grinberg <grinberg@compulab.co.il> Greg, Can you, please, add this as a fix (maybe urgent) for build failure? Thanks > Best regards > Uwe > > -- Regards, Igor. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi 2010-08-16 6:09 ` Igor Grinberg @ 2010-08-22 7:24 ` Igor Grinberg 2010-08-22 17:10 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Igor Grinberg @ 2010-08-22 7:24 UTC (permalink / raw) To: Uwe Kleine-König Cc: Greg Kroah-Hartman, Sergei Shtylyov, linux-usb, linux-kernel, Mike Rapoport, linux-arm-kernel Greg, ping... On 08/16/10 09:09, Igor Grinberg wrote: > On 08/16/10 07:53, Uwe Kleine-König wrote: >> Hello Igor, >> >> On Sun, Aug 15, 2010 at 09:05:59AM +0300, Igor Grinberg wrote: >> >>> On 08/13/10 15:06, Uwe Kleine-König wrote: >>> >>>> The build failure was introduced by >>>> >>>> 13dd0c9 (USB: otg/ulpi: extend the generic ulpi driver.) >>>> >>>> Cc: Igor Grinberg <grinberg@compulab.co.il> >>>> Cc: Mike Rapoport <mike@compulab.co.il> >>>> Cc: Greg Kroah-Hartman <gregkh@suse.de> >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >>>> >>>> >>> I've based my patches on v2.6.35-rc6, so I could not patch >>> those imx variants, sorry... >>> But I did deal with mach-pca100.c, so I think moving it from >>> mach-mx2 to mach-imx is what made it miss my patch. >>> >>> Anyway, this looks like the right addition. >>> >> I assume this is an Ack? >> > Acked-by: Igor Grinberg <grinberg@compulab.co.il> > > > Greg, > > Can you, please, add this as a fix (maybe urgent) for build failure? > > Thanks > >> Best regards >> Uwe >> >> -- Regards, Igor. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi 2010-08-22 7:24 ` Igor Grinberg @ 2010-08-22 17:10 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2010-08-22 17:10 UTC (permalink / raw) To: Igor Grinberg Cc: Uwe Kleine-K?nig, Sergei Shtylyov, linux-usb, linux-kernel, Mike Rapoport, linux-arm-kernel On Sun, Aug 22, 2010 at 10:24:59AM +0300, Igor Grinberg wrote: > Greg, > > ping... Sorry, it's in my queue, swamped with -stable work at the moment. Will get to Linus soon... greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-08-22 17:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1275464450-23003-2-git-send-email-grinberg@compulab.co.il>
2010-08-13 10:21 ` [PATCH] ARM: imx: fix build failure concerning otg/ulpi Uwe Kleine-König
2010-08-13 10:54 ` Sergei Shtylyov
2010-08-13 12:06 ` [PATCH v2] " Uwe Kleine-König
2010-08-15 6:05 ` Igor Grinberg
2010-08-16 4:53 ` Uwe Kleine-König
2010-08-16 6:09 ` Igor Grinberg
2010-08-22 7:24 ` Igor Grinberg
2010-08-22 17:10 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox