From: Mike Rapoport <mike@compulab.co.il>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Gary King <gking@nvidia.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameter for tps6586x_set_bits()
Date: Mon, 23 Aug 2010 13:09:07 +0300 [thread overview]
Message-ID: <4C7248C3.9040304@compulab.co.il> (raw)
In-Reply-To: <20100823100248.GG6061@rakim.wolfsonmicro.main>
Mark Brown wrote:
> On Sun, Aug 22, 2010 at 10:42:42PM +0800, Axel Lin wrote:
>> The third parameter of tps6586x_set_bits() is the bit_mask,
>> thus we should use (1 << ri->go_bit) instead of ri->go_bit.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> but I'd be much happier if someone who actually has the hardware could
> verify that this is OK.
I don't have the hardware handy at the moment.
Gary, can you please verify the fix?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2010-08-23 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 14:38 [PATCH 1/2] regulator: tps6586x-regulator - fix value range checking for val Axel Lin
2010-08-22 14:42 ` [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameter for tps6586x_set_bits() Axel Lin
2010-08-23 10:02 ` Mark Brown
2010-08-23 10:09 ` Mike Rapoport [this message]
2010-08-25 9:53 ` Liam Girdwood
2010-08-25 15:58 ` Gary King
2010-08-26 21:25 ` Gary King
2010-08-27 13:03 ` Liam Girdwood
2010-08-23 10:01 ` [PATCH 1/2] regulator: tps6586x-regulator - fix value range checking for val Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7248C3.9040304@compulab.co.il \
--to=mike@compulab.co.il \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gking@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox