From: Yinghai Lu <yinghai@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Daniel Kiper <dkiper@net-space.pl>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, apic: Fix apic=debug boot crash
Date: Mon, 23 Aug 2010 10:59:19 -0700 [thread overview]
Message-ID: <4C72B6F7.8010706@kernel.org> (raw)
In-Reply-To: <9cca0990-1b78-40e7-a71d-f550b4f504aa@email.android.com>
On 08/23/2010 07:54 AM, H. Peter Anvin wrote:
> It's already applied.
>
> "Daniel Kiper" <dkiper@net-space.pl> wrote:
>
>> Hi,
>>
>> On Fri, Aug 20, 2010 at 12:24:20PM -0700, Yinghai Lu wrote:
>>> On Fri, Aug 20, 2010 at 5:41 AM, tip-bot for Daniel Kiper
>>> <dkiper@net-space.pl> wrote:
>>>> Commit-ID: ?05e407603e527f9d808dd3866d3a17c2ce4dfcc5
>>>> Gitweb: ? ? http://git.kernel.org/tip/05e407603e527f9d808dd3866d3a17c2ce4dfcc5
>>>> Author: ? ? Daniel Kiper <dkiper@net-space.pl>
>>>> AuthorDate: Fri, 20 Aug 2010 00:46:16 +0200
>>>> Committer: ?Ingo Molnar <mingo@elte.hu>
>>>> CommitDate: Fri, 20 Aug 2010 10:18:28 +0200
>>>>
>>>> x86, apic: Fix apic=debug boot crash
>>>>
>>>> Fix a boot crash when apic=debug is used and the APIC is
>>>> not properly initialized.
>>>>
>>>> This issue appears during Xen Dom0 kernel boot but the
>>>> fix is generic and the crash could occur on real hardware
>>>> as well.
>>>
>>> Do you have any report on real hardware?
>>> that could not happen on real hardware.
>>
>> Till now no, however I think it is good idea
>> to apply this patch now. It is not worth to wait
>> for another null pointer dereference.
no, we should add BUG_ON() etc debug info there to see why that null cfg could happen.
because according to code, we should have null there.
Yinghai
next prev parent reply other threads:[~2010-08-23 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 22:46 [PATCH] arch/x86/kernel/apic/io_apic.c: Fix for crash when apic=debug is used Daniel Kiper
2010-08-20 12:41 ` [tip:x86/urgent] x86, apic: Fix apic=debug boot crash tip-bot for Daniel Kiper
2010-08-20 19:24 ` Yinghai Lu
2010-08-23 8:12 ` Daniel Kiper
2010-08-23 14:54 ` H. Peter Anvin
2010-08-23 17:59 ` Yinghai Lu [this message]
2010-08-24 21:39 ` Daniel Kiper
2010-08-24 21:47 ` Yinghai Lu
2010-08-25 13:51 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C72B6F7.8010706@kernel.org \
--to=yinghai@kernel.org \
--cc=dkiper@net-space.pl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox