Re: [RFC] mlock/stack guard interaction fixup

Linus Torvalds
2010-08-21T00:54:59Z

On Fri, Aug 20, 2010 at 5:20 PM, Mike Snitzer <snitzer@gmail.com> wrote:
>
> In 0002-mm-make-the-mlock-stack-guard-page-checks-stricter.patch you
> switch __mlock_vma_pages_range from 'start += PAGE_SIZE' to 'addr +=
> PAGE_SIZE'.
>
> So would that be a bugfix for commit d7824370?  Seems likely given
> start isn't used after that point.

Yup, that's a bug-fix. Although the real bug was having two variables
(addr and start) both be the same thing. Probably for some random
historical reason. And I didn't fix that.

Linus