From: Mike Rapoport <mike@compulab.co.il>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
eric miao <eric.y.miao@gmail.com>
Subject: Re: [PATCH 1/3] mfd: da903x - fix da903x_add_subdevs error path
Date: Tue, 24 Aug 2010 09:13:45 +0300 [thread overview]
Message-ID: <4C736319.6090701@compulab.co.il> (raw)
In-Reply-To: <1282628645.6074.1.camel@mola>
Axel Lin wrote:
> This patch fixes da903x_add_subdevs error path:
> 1. return -ENOMEM if platform_device_alloc() fail.
> 2. call platform_device_put() if platform_device_add() fail.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
> ---
> drivers/mfd/da903x.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index c07aece..2fadbae 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -470,13 +470,19 @@ static int __devinit da903x_add_subdevs(struct da903x_chip *chip,
> subdev = &pdata->subdevs[i];
>
> pdev = platform_device_alloc(subdev->name, subdev->id);
> + if (!pdev) {
> + ret = -ENOMEM;
> + goto failed;
> + }
>
> pdev->dev.parent = chip->dev;
> pdev->dev.platform_data = subdev->platform_data;
>
> ret = platform_device_add(pdev);
> - if (ret)
> + if (ret) {
> + platform_device_put(pdev);
> goto failed;
> + }
> }
> return 0;
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2010-08-24 6:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 5:44 [PATCH 1/3] mfd: da903x - fix da903x_add_subdevs error path Axel Lin
2010-08-24 5:45 ` [PATCH 2/3] mfd: ezx-pcap - fix pcap_add_subdev " Axel Lin
2010-08-24 5:47 ` [PATCH 3/3] mfd: tps6586x - fix tps6586x_add_subdevs " Axel Lin
2010-08-24 6:13 ` Mike Rapoport
2010-08-24 5:47 ` [PATCH 1/3] mfd: da903x - fix da903x_add_subdevs " Eric Miao
2010-08-24 6:13 ` Mike Rapoport [this message]
2010-09-10 15:53 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C736319.6090701@compulab.co.il \
--to=mike@compulab.co.il \
--cc=axel.lin@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox