Re: [PATCH 1/1] HPET: unmap unused I/O space

[Clemens Ladisch <clemens@ladisch.de>]

Jiri Slaby wrote:
> When the initialization code in hpet founds a memory resource and does
> not found IRQ, it does not unmap the memory resource previously
> mapped.
> [...]
> Since I got no reply previously, fix this by simply unmapping the
> space when IRQ is not found and memory region was mapped previously.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Clemens Ladisch <clemens@ladisch.de>

Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
>  drivers/char/hpet.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -1017,6 +1017,8 @@ static int hpet_acpi_add(struct acpi_device *device)
>  		return -ENODEV;
>  
>  	if (!data.hd_address || !data.hd_nirqs) {
> +		if (data.hd_address)
> +			iounmap(data.hd_address);
>  		printk("%s: no address or irqs in _CRS\n", __func__);
>  		return -ENODEV;
>  	}